From da8eba999657826a8dd8a611f5c62576749f6b44 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 20 Aug 2021 12:11:41 +0900
Subject: [PATCH] Return early to avoid updating state and failure count in
 fail cases

---
 osu.Game/Online/API/APIAccess.cs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/osu.Game/Online/API/APIAccess.cs b/osu.Game/Online/API/APIAccess.cs
index 96d62e95a2..af14cdc7b3 100644
--- a/osu.Game/Online/API/APIAccess.cs
+++ b/osu.Game/Online/API/APIAccess.cs
@@ -305,11 +305,13 @@ namespace osu.Game.Online.API
             {
                 req.Perform(this);
 
+                if (req.CompletionState != APIRequestCompletionState.Completed)
+                    return false;
+
                 // we could still be in initialisation, at which point we don't want to say we're Online yet.
                 if (IsLoggedIn) state.Value = APIState.Online;
-
                 failureCount = 0;
-                return req.CompletionState == APIRequestCompletionState.Completed;
+                return true;
             }
             catch (HttpRequestException re)
             {