RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-03-31 07:38:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve log output surrounding score submission

Browse Source
This commit is contained in:
Dean Herbert 2023-10-30 15:07:26 +09:00
parent 5ab20f5db7
commit d90f29a5ff
No known key found for this signature in database
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/Play/SubmittingPlayer.cs
View File

@ -188,7 +188,10 @@ namespace osu.Game.Screens.Play
{ {
// token may be null if the request failed but gameplay was still allowed (see HandleTokenRetrievalFailure). // token may be null if the request failed but gameplay was still allowed (see HandleTokenRetrievalFailure).
if (token == null) if (token == null)
{
Logger.Log("No token, skipping score submission");
return Task.CompletedTask; return Task.CompletedTask;
}
if (scoreSubmissionSource != null) if (scoreSubmissionSource != null)
return scoreSubmissionSource.Task; return scoreSubmissionSource.Task;
@ -197,6 +200,8 @@ namespace osu.Game.Screens.Play
if (!score.ScoreInfo.Statistics.Any(s => s.Key.IsHit() && s.Value > 0)) if (!score.ScoreInfo.Statistics.Any(s => s.Key.IsHit() && s.Value > 0))
return Task.CompletedTask; return Task.CompletedTask;
Logger.Log($"Beginning score submission (token:{token.Value})...");
scoreSubmissionSource = new TaskCompletionSource<bool>(); scoreSubmissionSource = new TaskCompletionSource<bool>();
var request = CreateSubmissionRequest(score, token.Value); var request = CreateSubmissionRequest(score, token.Value);
@ -206,11 +211,12 @@ namespace osu.Game.Screens.Play
score.ScoreInfo.Position = s.Position; score.ScoreInfo.Position = s.Position;
scoreSubmissionSource.SetResult(true); scoreSubmissionSource.SetResult(true);
Logger.Log($"Score submission completed! (token:{token.Value} id:{s.ID})");
}; };
request.Failure += e => request.Failure += e =>
{ {
Logger.Error(e, $"Failed to submit score ({e.Message})"); Logger.Error(e, $"Failed to submit score (token:{token.Value}): {e.Message}");
scoreSubmissionSource.SetResult(false); scoreSubmissionSource.SetResult(false);
}; };