From d7b939277e81d99eb36aeb25f9aa71846b8b90c6 Mon Sep 17 00:00:00 2001
From: dekrain <dawidkrainski8@gmail.com>
Date: Tue, 1 Feb 2022 07:10:00 +0100
Subject: [PATCH] Code quality improvements

---
 .../Leaderboards/LeaderboardScoreTooltip.cs   | 27 ++++++++++---------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/osu.Game/Online/Leaderboards/LeaderboardScoreTooltip.cs b/osu.Game/Online/Leaderboards/LeaderboardScoreTooltip.cs
index ea02c238f3..0b2de3e2c8 100644
--- a/osu.Game/Online/Leaderboards/LeaderboardScoreTooltip.cs
+++ b/osu.Game/Online/Leaderboards/LeaderboardScoreTooltip.cs
@@ -19,10 +19,10 @@ namespace osu.Game.Online.Leaderboards
 {
     public class LeaderboardScoreTooltip : VisibilityContainer, ITooltip<ScoreInfo>
     {
-        private OsuSpriteText timestampLabel;
-        private FillFlowContainer<HitResultCell> topScoreStatistics;
-        private FillFlowContainer<HitResultCell> bottomScoreStatistics;
-        private FillFlowContainer<ModCell> modStatistics;
+        private readonly OsuSpriteText timestampLabel;
+        private readonly FillFlowContainer<HitResultCell> topScoreStatistics;
+        private readonly FillFlowContainer<HitResultCell> bottomScoreStatistics;
+        private readonly FillFlowContainer<ModCell> modStatistics;
 
         public LeaderboardScoreTooltip()
         {
@@ -58,7 +58,7 @@ namespace osu.Game.Online.Leaderboards
                         // Info row
                         new Drawable[]
                         {
-                            timestampLabel = new OsuSpriteText()
+                            timestampLabel = new OsuSpriteText
                             {
                                 Font = OsuFont.GetFont(size: 12, weight: FontWeight.SemiBold),
                             }
@@ -98,8 +98,9 @@ namespace osu.Game.Online.Leaderboards
 
         public void SetContent(ScoreInfo score)
         {
-            if (currentScore == score)
+            if (currentScore.Equals(score))
                 return;
+
             currentScore = score;
 
             timestampLabel.Text = $"Played on {score.Date.ToLocalTime():d MMMM yyyy HH:mm}";
@@ -116,9 +117,9 @@ namespace osu.Game.Online.Leaderboards
             foreach (var result in score.GetStatisticsForDisplay())
             {
                 (result.Result > HitResult.Perfect
-                    ? bottomScoreStatistics
-                    : topScoreStatistics
-                ).Add(new HitResultCell(result));
+                        ? bottomScoreStatistics
+                        : topScoreStatistics
+                        ).Add(new HitResultCell(result));
             }
         }
 
@@ -129,9 +130,9 @@ namespace osu.Game.Online.Leaderboards
 
         private class HitResultCell : CompositeDrawable
         {
-            readonly private string DisplayName;
-            readonly private HitResult Result;
-            readonly private int Count;
+            private readonly string DisplayName;
+            private readonly HitResult Result;
+            private readonly int Count;
 
             public HitResultCell(HitResultDisplayStatistic stat)
             {
@@ -190,7 +191,7 @@ namespace osu.Game.Online.Leaderboards
 
         private class ModCell : CompositeDrawable
         {
-            readonly private Mod Mod;
+            private readonly Mod Mod;
 
             public ModCell(Mod mod)
             {