RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove now unnecessary `BeatmapDifficulty.ID`

This commit is contained in:
Dean Herbert 2021-07-08 14:29:30 +09:00
parent 0e4f4a6fde
commit d540156e94
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Tests/Mods/ModDifficultyAdjustTest.cs
View File

@ -15,23 +15,12 @@ namespace osu.Game.Tests.Mods
[TestFixture] [TestFixture]
public class ModDifficultyAdjustTest public class ModDifficultyAdjustTest
{ {
// Todo: This shouldn't exist, but is currently required for the mod to accept a new BeatmapDifficulty object...
private int currentId;
private TestModDifficultyAdjust testMod; private TestModDifficultyAdjust testMod;
[SetUp] [SetUp]
public void Setup() public void Setup()
{ {
currentId = 0;
testMod = new TestModDifficultyAdjust(); testMod = new TestModDifficultyAdjust();
// Todo: This shouldn't be a thing, but is currently required because this causes the mod to keep track of the bindables internally...
applyDifficulty(new BeatmapDifficulty
{
DrainRate = -1,
OverallDifficulty = -1
});
} }
[Test] [Test]
@ -136,7 +125,6 @@ private BeatmapDifficulty applyDifficulty(BeatmapDifficulty difficulty)
// ensure that ReadFromDifficulty doesn't pollute the values. // ensure that ReadFromDifficulty doesn't pollute the values.
var newDifficulty = difficulty.Clone(); var newDifficulty = difficulty.Clone();
difficulty.ID = ++currentId;
testMod.ReadFromDifficulty(difficulty); testMod.ReadFromDifficulty(difficulty);
testMod.ApplyToDifficulty(newDifficulty); testMod.ApplyToDifficulty(newDifficulty);