RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-15 03:16:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Remove sound from notification closing/hiding"

Browse Source 
This reverts commit 244f3c6098bb27b66f5ff7fb8c76f38f56cfb4cd.
This commit is contained in:
Jamie Taylor 2023-07-07 01:06:09 +09:00
parent 6e2b7f433b
commit d4f5d0c878
No known key found for this signature in database
GPG Key ID: 2ACFA8B6370B8C8C
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Overlays/NotificationOverlay.cs
View File

@ -229,7 +229,14 @@ namespace osu.Game.Overlays
mainContent.FadeEdgeEffectTo(0, WaveContainer.DISAPPEAR_DURATION, Easing.In);
}
private void notificationClosed() => Schedule(updateCounts);
private void notificationClosed() => Schedule(() =>
{
updateCounts();
// this debounce is currently shared between popin/popout sounds, which means one could potentially not play when the user is expecting it.
// popout is constant across all notification types, and should therefore be handled using playback concurrency instead, but seems broken at the moment.
playDebouncedSample("UI/overlay-pop-out");
});
private void playDebouncedSample(string sampleName)
{