RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-23 23:33:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix first word bold not applying correctly after first language change

Browse Source 
Closes https://github.com/ppy/osu/issues/27549.

I'm not entirely sure why the old solution failed exactly, but also
think it's unimportant because I think past me was an idiot and was
playing stupid games with the juggling of indices between two callbacks
with no ordering guarantees and expecting not to win stupid prizes.

I'm not sure this requires any follow-up reconsiderations of that entire
text flow API, but if opinions differ, I'll re-examine.
This commit is contained in:
Bartłomiej Dach 2024-03-13 15:18:20 +01:00
parent c575cce10c
commit d32f19b546
No known key found for this signature in database
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
osu.Game/Overlays/Mods/ModSelectColumn.cs
View File

@ -1,6 +1,7 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
@ -8,9 +9,11 @@ using osu.Framework.Graphics.Colour;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Shapes;
using osu.Framework.Localisation;
using System.Linq;
using osu.Game.Graphics;
using osu.Game.Graphics.Backgrounds;
using osu.Game.Graphics.Containers;
using osu.Game.Graphics.Sprites;
using osuTK;
using osuTK.Graphics;
@ -181,17 +184,15 @@ namespace osu.Game.Overlays.Mods
{
headerText.Clear();
int wordIndex = 0;
ITextPart part = headerText.AddText(text);
part.DrawablePartsRecreated += applySemiBoldToFirstWord;
applySemiBoldToFirstWord(part.Drawables);
ITextPart part = headerText.AddText(text, t =>
void applySemiBoldToFirstWord(IEnumerable<Drawable> d)
{
if (wordIndex == 0)
t.Font = t.Font.With(weight: FontWeight.SemiBold);
wordIndex += 1;
});
// Reset the index so that if the parts are refreshed (e.g. through changes in localisation) the correct word is re-emboldened.
part.DrawablePartsRecreated += _ => wordIndex = 0;
if (d.FirstOrDefault() is OsuSpriteText firstWord)
firstWord.Font = firstWord.Font.With(weight: FontWeight.SemiBold);
}
}
[BackgroundDependencyLoader]