From d21464ea61b8efcf53eb867970b8bf4a5013a109 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Sun, 30 Jan 2022 02:54:51 +0900
Subject: [PATCH] Fix assertions to work in both directions

---
 .../Visual/SongSelect/TestSceneBeatmapLeaderboard.cs     | 1 +
 osu.Game/Online/Leaderboards/Leaderboard.cs              | 9 +++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapLeaderboard.cs b/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapLeaderboard.cs
index 91ec1de3ad..31b7b9fa8d 100644
--- a/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapLeaderboard.cs
+++ b/osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapLeaderboard.cs
@@ -414,6 +414,7 @@ namespace osu.Game.Tests.Visual.SongSelect
         {
             public void SetRetrievalState(PlaceholderState state)
             {
+                Scores = null;
                 PlaceholderState = state;
             }
 
diff --git a/osu.Game/Online/Leaderboards/Leaderboard.cs b/osu.Game/Online/Leaderboards/Leaderboard.cs
index 460869fa54..7b596d8381 100644
--- a/osu.Game/Online/Leaderboards/Leaderboard.cs
+++ b/osu.Game/Online/Leaderboards/Leaderboard.cs
@@ -243,11 +243,10 @@ namespace osu.Game.Online.Leaderboards
 
                 placeholderState = value;
 
-                Debug.Assert(placeholderState != PlaceholderState.Successful || scores?.Any() == true);
-
                 switch (placeholderState)
                 {
                     case PlaceholderState.NetworkFailure:
+                        Debug.Assert(scores?.Any() != true);
                         replacePlaceholder(new ClickablePlaceholder(@"Couldn't fetch scores!", FontAwesome.Solid.Sync)
                         {
                             Action = RefetchScores
@@ -255,26 +254,32 @@ namespace osu.Game.Online.Leaderboards
                         break;
 
                     case PlaceholderState.NoneSelected:
+                        Debug.Assert(scores?.Any() != true);
                         replacePlaceholder(new MessagePlaceholder(@"Please select a beatmap!"));
                         break;
 
                     case PlaceholderState.Unavailable:
+                        Debug.Assert(scores?.Any() != true);
                         replacePlaceholder(new MessagePlaceholder(@"Leaderboards are not available for this beatmap!"));
                         break;
 
                     case PlaceholderState.NoScores:
+                        Debug.Assert(scores?.Any() != true);
                         replacePlaceholder(new MessagePlaceholder(@"No records yet!"));
                         break;
 
                     case PlaceholderState.NotLoggedIn:
+                        Debug.Assert(scores?.Any() != true);
                         replacePlaceholder(new LoginPlaceholder(@"Please sign in to view online leaderboards!"));
                         break;
 
                     case PlaceholderState.NotSupporter:
+                        Debug.Assert(scores?.Any() != true);
                         replacePlaceholder(new MessagePlaceholder(@"Please invest in an osu!supporter tag to view this leaderboard!"));
                         break;
 
                     default:
+                        Debug.Assert(scores?.Any() == true);
                         replacePlaceholder(null);
                         break;
                 }