RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move constant to a better location

This commit is contained in:
Dean Herbert 2022-11-18 15:47:31 +09:00
parent 3faa7f5f74
commit d17c091d63
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Online/API/Requests/GetScoresRequest.cs
View File

@ -16,6 +16,8 @@ namespace osu.Game.Online.API.Requests
{
public class GetScoresRequest : APIRequest<APIScoresCollection>
{
public const int MAX_SCORES_PER_REQUEST = 50;
private readonly IBeatmapInfo beatmapInfo;
private readonly BeatmapLeaderboardScope scope;
private readonly IRulesetInfo ruleset;

4
osu.Game/Screens/Play/HUD/SoloGameplayLeaderboard.cs
View File

@ -7,6 +7,7 @@
using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Game.Configuration;
using osu.Game.Online.API.Requests;
using osu.Game.Rulesets.Scoring;
using osu.Game.Scoring;
using osu.Game.Screens.Select;
@ -17,7 +18,6 @@ namespace osu.Game.Screens.Play.HUD
public class SoloGameplayLeaderboard : GameplayLeaderboard
{
private const int duration = 100;
private const int max_online_scores = 50; // BAD!
private readonly Bindable<bool> configVisibility = new Bindable<bool>();
private readonly IUser trackingUser;
@ -107,7 +107,7 @@ protected override void sort()
if (scoresType.Value != PlayBeatmapDetailArea.TabType.Local)
{
// change displayed potision to '-' when there are 50 already submitted scores and tracked score is last
if (TrackedScore?.ScorePosition == Flow.Count && Flow.Count > max_online_scores)
if (TrackedScore?.ScorePosition == Flow.Count && Flow.Count > GetScoresRequest.MAX_SCORES_PER_REQUEST)
TrackedScore.ScorePosition = null;
}
}