RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

revert overwriting Position getter in SliderTailCircle 

It would have very weird implications when combined with the position bindable which would be all wrong and stuff
This commit is contained in:
OliBomby 2024-01-13 13:54:04 +01:00
parent fca9b1f536
commit ce643aa68f
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Rulesets.Osu/Objects/Slider.cs
View File

@ -218,6 +218,7 @@ protected override void CreateNestedHitObjects(CancellationToken cancellationTok
{
RepeatIndex = e.SpanIndex,
StartTime = e.Time,
Position = EndPosition,
StackHeight = StackHeight,
ClassicSliderBehaviour = ClassicSliderBehaviour,
});
@ -244,6 +245,9 @@ private void updateNestedPositions()
if (HeadCircle != null)
HeadCircle.Position = Position;
if (TailCircle != null)
TailCircle.Position = EndPosition;
}
protected void UpdateNestedSamples()

8
osu.Game.Rulesets.Osu/Objects/SliderTailCircle.cs
View File

@ -1,11 +1,9 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System;
using osu.Game.Rulesets.Judgements;
using osu.Game.Rulesets.Osu.Judgements;
using osu.Game.Rulesets.Scoring;
using osuTK;
namespace osu.Game.Rulesets.Osu.Objects
{
@ -17,12 +15,6 @@ public class SliderTailCircle : SliderEndCircle
/// </summary>
public bool ClassicSliderBehaviour;
public override Vector2 Position
{
get => Slider.EndPosition;
set => throw new NotImplementedException();
}
public SliderTailCircle(Slider slider)
: base(slider)
{