RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove `Statistics` from interface until we figure how to properly deserialise

This commit is contained in:
Dean Herbert 2021-10-29 14:18:10 +09:00
parent 3f030cebf4
commit cd7bd935f6
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Online/API/Requests/Responses/APIScoreInfo.cs
View File

@ -9,7 +9,6 @@
using osu.Game.Beatmaps;
using osu.Game.Rulesets;
using osu.Game.Rulesets.Mods;
using osu.Game.Rulesets.Scoring;
using osu.Game.Scoring;
using osu.Game.Scoring.Legacy;
using osu.Game.Users;
@ -141,7 +140,5 @@ public ScoreInfo CreateScoreInfo(RulesetStore rulesets, BeatmapInfo beatmap = nu
public IRulesetInfo Ruleset => new RulesetInfo { ID = OnlineRulesetID };
IBeatmapInfo IScoreInfo.Beatmap => Beatmap;
Dictionary<HitResult, int> IScoreInfo.Statistics => new Dictionary<HitResult, int>(); // TODO: implement... maybe. hitresults have weird mappings per ruleset it would seem.
}
}

6
osu.Game/Scoring/IScoreInfo.cs
View File

@ -2,11 +2,9 @@
// See the LICENCE file in the repository root for full licence text.
using System;
using System.Collections.Generic;
using osu.Game.Beatmaps;
using osu.Game.Database;
using osu.Game.Rulesets;
using osu.Game.Rulesets.Scoring;
using osu.Game.Users;
namespace osu.Game.Scoring
@ -29,13 +27,13 @@ public interface IScoreInfo : IHasOnlineID<long>
IBeatmapInfo Beatmap { get; }
Dictionary<HitResult, int> Statistics { get; }
IRulesetInfo Ruleset { get; }
public ScoreRank Rank { get; }
// Mods is currently missing from this interface as the `IMod` class has properties which can't be fulfilled by `APIMod`,
// but also doesn't expose `Settings`. We can consider how to implement this in the future if required.
// Statistics is also missing. This can be reconsidered once changes in serialisation have been completed.
}
}