mirror of https://github.com/ppy/osu
Add missing string function ordinal specifications
This commit is contained in:
parent
39a74536f2
commit
cc41845f56
|
@ -234,7 +234,7 @@ private void reset(bool loadLastResults = false)
|
|||
if (string.IsNullOrEmpty(line))
|
||||
continue;
|
||||
|
||||
if (line.ToUpperInvariant().StartsWith("GROUP"))
|
||||
if (line.ToUpperInvariant().StartsWith("GROUP", StringComparison.Ordinal))
|
||||
continue;
|
||||
|
||||
// ReSharper disable once AccessToModifiedClosure
|
||||
|
|
|
@ -92,7 +92,7 @@ protected void HandleColours<TModel>(TModel output, string line)
|
|||
{
|
||||
var pair = SplitKeyVal(line);
|
||||
|
||||
bool isCombo = pair.Key.StartsWith(@"Combo");
|
||||
bool isCombo = pair.Key.StartsWith(@"Combo", StringComparison.Ordinal);
|
||||
|
||||
string[] split = pair.Value.Split(',');
|
||||
|
||||
|
|
|
@ -181,7 +181,7 @@ private void load()
|
|||
|
||||
if (args?.Length > 0)
|
||||
{
|
||||
var paths = args.Where(a => !a.StartsWith(@"-")).ToArray();
|
||||
var paths = args.Where(a => !a.StartsWith(@"-", StringComparison.Ordinal)).ToArray();
|
||||
if (paths.Length > 0)
|
||||
Task.Run(() => Import(paths));
|
||||
}
|
||||
|
@ -289,7 +289,7 @@ public void HandleLink(LinkDetails link) => Schedule(() =>
|
|||
|
||||
public void OpenUrlExternally(string url) => waitForReady(() => externalLinkOpener, _ =>
|
||||
{
|
||||
if (url.StartsWith("/"))
|
||||
if (url.StartsWith("/", StringComparison.Ordinal))
|
||||
url = $"{API.Endpoint}{url}";
|
||||
|
||||
externalLinkOpener.OpenUrlExternally(url);
|
||||
|
|
|
@ -100,7 +100,7 @@ private void addMissingRulesets()
|
|||
{
|
||||
// todo: StartsWith can be changed to Equals on 2020-11-08
|
||||
// This is to give users enough time to have their database use new abbreviated info).
|
||||
if (context.RulesetInfo.FirstOrDefault(ri => ri.InstantiationInfo.StartsWith(r.RulesetInfo.InstantiationInfo)) == null)
|
||||
if (context.RulesetInfo.FirstOrDefault(ri => ri.InstantiationInfo.StartsWith(r.RulesetInfo.InstantiationInfo, StringComparison.Ordinal)) == null)
|
||||
context.RulesetInfo.Add(r.RulesetInfo);
|
||||
}
|
||||
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
||||
// See the LICENCE file in the repository root for full licence text.
|
||||
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Diagnostics;
|
||||
using System.Globalization;
|
||||
|
@ -115,16 +116,16 @@ private void flushPendingLines()
|
|||
currentConfig.MinimumColumnWidth = minWidth;
|
||||
break;
|
||||
|
||||
case string _ when pair.Key.StartsWith("Colour"):
|
||||
case string _ when pair.Key.StartsWith("Colour", StringComparison.Ordinal):
|
||||
HandleColours(currentConfig, line);
|
||||
break;
|
||||
|
||||
// Custom sprite paths
|
||||
case string _ when pair.Key.StartsWith("NoteImage"):
|
||||
case string _ when pair.Key.StartsWith("KeyImage"):
|
||||
case string _ when pair.Key.StartsWith("Hit"):
|
||||
case string _ when pair.Key.StartsWith("Stage"):
|
||||
case string _ when pair.Key.StartsWith("Lighting"):
|
||||
case string _ when pair.Key.StartsWith("NoteImage", StringComparison.Ordinal):
|
||||
case string _ when pair.Key.StartsWith("KeyImage", StringComparison.Ordinal):
|
||||
case string _ when pair.Key.StartsWith("Hit", StringComparison.Ordinal):
|
||||
case string _ when pair.Key.StartsWith("Stage", StringComparison.Ordinal):
|
||||
case string _ when pair.Key.StartsWith("Lighting", StringComparison.Ordinal):
|
||||
currentConfig.ImageLookups[pair.Key] = pair.Value;
|
||||
break;
|
||||
}
|
||||
|
|
|
@ -45,7 +45,7 @@ public SentryLogger(OsuGame game)
|
|||
|
||||
// since we let unhandled exceptions go ignored at times, we want to ensure they don't get submitted on subsequent reports.
|
||||
if (lastException != null &&
|
||||
lastException.Message == exception.Message && exception.StackTrace.StartsWith(lastException.StackTrace))
|
||||
lastException.Message == exception.Message && exception.StackTrace.StartsWith(lastException.StackTrace, StringComparison.Ordinal))
|
||||
return;
|
||||
|
||||
lastException = exception;
|
||||
|
|
Loading…
Reference in New Issue