RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

simplify code

This commit is contained in:
Aki 2023-07-16 10:21:32 +08:00
parent 309c852222
commit cb354685ca
No known key found for this signature in database
GPG Key ID: 71EB4ADB554E1DCC
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Scoring/ScoreInfoExtensions.cs
View File

@ -32,13 +32,5 @@ public static IEnumerable<ScoreInfo> OrderByTotalScore(this IEnumerable<ScoreInf
/// <param name="score">The <see cref="ScoreInfo"/> to compute the maximum achievable combo for.</param>
/// <returns>The maximum achievable combo.</returns>
public static int GetMaximumAchievableCombo(this ScoreInfo score) => score.MaximumStatistics.Where(kvp => kvp.Key.AffectsCombo()).Sum(kvp => kvp.Value);
/// <summary>
/// Retrieves the <see cref="ScoreInfo"/> with the maximum total score.
/// </summary>
/// <param name="scores">An array of <see cref="ScoreInfo"/>s to retrieve the scoreInfo with maximum total score.</param>
/// <returns>The <see cref="ScoreInfo"/> instance with the maximum total score.</returns>
public static ScoreInfo? MaxByTopScore(this IEnumerable<ScoreInfo> scores)
=> scores.MaxBy(info => (info.TotalScore, -info.OnlineID, -info.Date.UtcDateTime.Ticks));
}
}

4
osu.Game/Screens/Select/Carousel/TopLocalRank.cs
View File

@ -2,6 +2,7 @@
// See the LICENCE file in the repository root for full licence text.
using System;
using System.Linq;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
@ -74,8 +75,7 @@ void localScoresChanged(IRealmCollection<ScoreInfo> sender, ChangeSet? changes)
if (changes?.HasCollectionChanges() == false)
return;
ScoreInfo? topScore = sender.MaxByTopScore();
ScoreInfo? topScore = sender.MaxBy(info => (info.TotalScore, -info.Date.UtcDateTime.Ticks));
updateable.Rank = topScore?.Rank;
updateable.Alpha = topScore != null ? 1 : 0;
}