Use better safety in rectangular grid

- Checking `DrawSize != Vector2.Zero` is too specific. It could also
  crash on zero-height-but-non-zero-width, or
  zero-width-but-non-zero-height.

- Take the `gridCache.Validate()` call out of the zero checks, because
  even if the width or height are zero, not generating anything is valid
  and there is no reason to validate every frame until `gridCache` gets
  invalidated again.
This commit is contained in:
Bartłomiej Dach 2023-07-28 22:57:02 +02:00
parent 0c10d875ce
commit c6f0cf50ca
No known key found for this signature in database

View File

@ -55,11 +55,10 @@ namespace osu.Game.Screens.Edit.Compose.Components
{ {
ClearInternal(); ClearInternal();
if (DrawSize != Vector2.Zero) if (DrawWidth > 0 && DrawHeight > 0)
{
createContent(); createContent();
gridCache.Validate();
} gridCache.Validate();
} }
} }