RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove `MultiplayerMatchSubScreen` flaky test attribute 

Didn't really work to fix these tests due to the sticky nature of the
failure. Also I can no longer reproduce locally, so the hope is that
these are fixed by https://github.com/ppy/osu/pull/30634.
This commit is contained in:
Dean Herbert 2024-11-20 17:11:49 +09:00
parent 03de518484
commit c6d08daee8
No known key found for this signature in database
1 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerMatchSubScreen.cs
View File

@ -77,25 +77,6 @@ public void SetupSteps()
} }
[Test] [Test]
[FlakyTest]
/*
* Fail rate around 1.5%
*
* TearDown : System.AggregateException : One or more errors occurred. (Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index'))
----> System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
* --TearDown
* at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
* at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
* at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task)
* at osu.Framework.Testing.TestScene.checkForErrors()
* at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
*--ArgumentOutOfRangeException
* at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, BindableList`1 caller)
* at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, BindableList`1 caller)
* at osu.Framework.Bindables.BindableList`1.removeAt(Int32 index, BindableList`1 caller)
* at osu.Game.Online.Multiplayer.MultiplayerClient.<>c__DisplayClass106_0.<PlaylistItemChanged>b__0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Online\Multiplayer\MultiplayerClient .cs:line 702
* at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
*/
public void TestCreatedRoom() public void TestCreatedRoom()
{ {
AddStep("add playlist item", () => AddStep("add playlist item", () =>
@ -115,7 +96,6 @@ public void TestCreatedRoom()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestTaikoOnlyMod() public void TestTaikoOnlyMod()
{ {
AddStep("add playlist item", () => AddStep("add playlist item", () =>
@ -139,7 +119,6 @@ public void TestTaikoOnlyMod()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestSettingValidity() public void TestSettingValidity()
{ {
AddAssert("create button not enabled", () => !this.ChildrenOfType<MultiplayerMatchSettingsOverlay.CreateOrUpdateButton>().Single().Enabled.Value); AddAssert("create button not enabled", () => !this.ChildrenOfType<MultiplayerMatchSettingsOverlay.CreateOrUpdateButton>().Single().Enabled.Value);
@ -159,7 +138,6 @@ public void TestSettingValidity()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestStartMatchWhileSpectating() public void TestStartMatchWhileSpectating()
{ {
AddStep("set playlist", () => AddStep("set playlist", () =>
@ -191,7 +169,6 @@ public void TestStartMatchWhileSpectating()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestFreeModSelectionHasAllowedMods() public void TestFreeModSelectionHasAllowedMods()
{ {
AddStep("add playlist item with allowed mod", () => AddStep("add playlist item with allowed mod", () =>
@ -221,7 +198,6 @@ public void TestFreeModSelectionHasAllowedMods()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestModSelectKeyWithAllowedMods() public void TestModSelectKeyWithAllowedMods()
{ {
AddStep("add playlist item with allowed mod", () => AddStep("add playlist item with allowed mod", () =>
@ -246,7 +222,6 @@ public void TestModSelectKeyWithAllowedMods()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestModSelectKeyWithNoAllowedMods() public void TestModSelectKeyWithNoAllowedMods()
{ {
AddStep("add playlist item with no allowed mods", () => AddStep("add playlist item with no allowed mods", () =>
@ -270,7 +245,6 @@ public void TestModSelectKeyWithNoAllowedMods()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestNextPlaylistItemSelectedAfterCompletion() public void TestNextPlaylistItemSelectedAfterCompletion()
{ {
AddStep("add two playlist items", () => AddStep("add two playlist items", () =>
@ -307,7 +281,6 @@ public void TestNextPlaylistItemSelectedAfterCompletion()
} }
[Test] [Test]
[FlakyTest] // See above
public void TestModSelectOverlay() public void TestModSelectOverlay()
{ {
AddStep("add playlist item", () => AddStep("add playlist item", () =>