From c609e6345cf6c3b41b57917fe1dac841b1be9a4c Mon Sep 17 00:00:00 2001
From: cdwcgt <cdwcgt@cdwcgt.top>
Date: Wed, 3 May 2023 23:01:31 +0900
Subject: [PATCH] remove `Use Current Mods` menu item

---
 .../UserInterface/TestSceneModPresetColumn.cs | 44 -------------------
 osu.Game/Overlays/Mods/ModPresetPanel.cs      | 21 ++-------
 2 files changed, 4 insertions(+), 61 deletions(-)

diff --git a/osu.Game.Tests/Visual/UserInterface/TestSceneModPresetColumn.cs b/osu.Game.Tests/Visual/UserInterface/TestSceneModPresetColumn.cs
index 55fe142d9f..0cbbe00311 100644
--- a/osu.Game.Tests/Visual/UserInterface/TestSceneModPresetColumn.cs
+++ b/osu.Game.Tests/Visual/UserInterface/TestSceneModPresetColumn.cs
@@ -392,50 +392,6 @@ public void TestEditPresetMod()
                 new HashSet<Mod>(this.ChildrenOfType<ModPresetPanel>().First().Preset.Value.Mods).SetEquals(mods));
         }
 
-        [Test]
-        public void TestEditPresetModInContextMenu()
-        {
-            ModPresetColumn modPresetColumn = null!;
-            var mods = new Mod[] { new OsuModHidden() };
-
-            AddStep("clear mods", () => SelectedMods.Value = Array.Empty<Mod>());
-            AddStep("create content", () => Child = modPresetColumn = new ModPresetColumn
-            {
-                Anchor = Anchor.Centre,
-                Origin = Anchor.Centre,
-            });
-
-            AddUntilStep("items loaded", () => modPresetColumn.IsLoaded && modPresetColumn.ItemsLoaded);
-
-            AddStep("right click first panel", () =>
-            {
-                var panel = this.ChildrenOfType<ModPresetPanel>().First();
-                InputManager.MoveMouseTo(panel);
-                InputManager.Click(MouseButton.Right);
-            });
-            AddUntilStep("wait for context menu", () => this.ChildrenOfType<OsuContextMenu>().Any());
-            AddAssert("No Use Current Mods", () => this.ChildrenOfType<DrawableOsuMenuItem>().Count() == 2);
-
-            AddStep("select mods", () => SelectedMods.Value = mods);
-            AddStep("right click second panel", () =>
-            {
-                var panel = this.ChildrenOfType<ModPresetPanel>().ElementAt(1);
-                InputManager.MoveMouseTo(panel);
-                InputManager.Click(MouseButton.Right);
-            });
-
-            AddUntilStep("wait for context menu", () => this.ChildrenOfType<OsuContextMenu>().Any());
-            AddAssert("Have Use Current Mods", () => this.ChildrenOfType<DrawableOsuMenuItem>().Count() == 3);
-            AddStep("Click Use Current Mods", () =>
-            {
-                var editItem = this.ChildrenOfType<DrawableOsuMenuItem>().ElementAt(1);
-                InputManager.MoveMouseTo(editItem);
-                InputManager.Click(MouseButton.Left);
-            });
-            AddAssert("present mod is changed", () =>
-                new HashSet<Mod>(this.ChildrenOfType<ModPresetPanel>().ElementAt(1).Preset.Value.Mods).SetEquals(mods));
-        }
-
         private ICollection<ModPreset> createTestPresets() => new[]
         {
             new ModPreset
diff --git a/osu.Game/Overlays/Mods/ModPresetPanel.cs b/osu.Game/Overlays/Mods/ModPresetPanel.cs
index d01981d18c..6999f2cede 100644
--- a/osu.Game/Overlays/Mods/ModPresetPanel.cs
+++ b/osu.Game/Overlays/Mods/ModPresetPanel.cs
@@ -90,24 +90,11 @@ private void updateActiveState()
 
         #region IHasContextMenu
 
-        public MenuItem[] ContextMenuItems
+        public MenuItem[] ContextMenuItems => new MenuItem[]
         {
-            get
-            {
-                var menu = new List<MenuItem>
-                {
-                    new OsuMenuItem(CommonStrings.ButtonsEdit, MenuItemType.Highlighted, this.ShowPopover),
-                    new OsuMenuItem(CommonStrings.ButtonsDelete, MenuItemType.Destructive, () => dialogOverlay?.Push(new DeleteModPresetDialog(Preset))),
-                };
-
-                if (CheckCurrentModCanBeSave())
-                {
-                    menu.Insert(1, new OsuMenuItem("Use Current Mods", MenuItemType.Destructive, () => SaveCurrentMod()));
-                }
-
-                return menu.ToArray();
-            }
-        }
+            new OsuMenuItem(CommonStrings.ButtonsEdit, MenuItemType.Highlighted, this.ShowPopover),
+            new OsuMenuItem(CommonStrings.ButtonsDelete, MenuItemType.Destructive, () => dialogOverlay?.Push(new DeleteModPresetDialog(Preset))),
+        };
 
         #endregion