Merge pull request #1855 from smoogipoo/ci-cleaunps

Cleanup some possible CI errors

osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs

@@ -64,24 +64,24 @@ namespace osu.Game.Beatmaps.ControlPoints
         /// <returns>The timing control point.</returns>
         public TimingControlPoint TimingPointAt(double time) => binarySearch(TimingPoints, time, TimingPoints.FirstOrDefault());
 
-        [JsonIgnore]
         /// <summary>
         /// Finds the maximum BPM represented by any timing control point.
         /// </summary>
+        [JsonIgnore]
         public double BPMMaximum =>
             60000 / (TimingPoints.OrderBy(c => c.BeatLength).FirstOrDefault() ?? new TimingControlPoint()).BeatLength;
 
-        [JsonIgnore]
         /// <summary>
         /// Finds the minimum BPM represented by any timing control point.
         /// </summary>
+        [JsonIgnore]
         public double BPMMinimum =>
             60000 / (TimingPoints.OrderByDescending(c => c.BeatLength).FirstOrDefault() ?? new TimingControlPoint()).BeatLength;
 
-        [JsonIgnore]
         /// <summary>
         /// Finds the mode BPM (most common BPM) represented by the control points.
         /// </summary>
+        [JsonIgnore]
         public double BPMMode =>
             60000 / (TimingPoints.GroupBy(c => c.BeatLength).OrderByDescending(grp => grp.Count()).FirstOrDefault()?.FirstOrDefault() ?? new TimingControlPoint()).BeatLength;
 

osu.Game/Graphics/UserInterface/LineGraph.cs

@@ -73,8 +73,6 @@ namespace osu.Game.Graphics.UserInterface
             });
         }
 
-        private bool pending;
-
         public override bool Invalidate(Invalidation invalidation = Invalidation.All, Drawable source = null, bool shallPropagate = true)
         {
             if ((invalidation & Invalidation.DrawSize) > 0)

osu.Game/IO/Serialization/Converters/TypedListConverter.cs

@@ -9,11 +9,11 @@ using Newtonsoft.Json.Linq;
 namespace osu.Game.IO.Serialization.Converters
 {
     /// <summary>
-    /// A type of <see cref="JsonConverter"/> that serializes a <see cref="List<T>"/> alongside
+    /// A type of <see cref="JsonConverter"/> that serializes a <see cref="List{T}"/> alongside
     /// a lookup table for the types contained. The lookup table is used in deserialization to
     /// reconstruct the objects with their original types.
     /// </summary>
-    /// <typeparam name="T">The type of objects contained in the <see cref="List<T>"/> this attribute is attached to.</typeparam>
+    /// <typeparam name="T">The type of objects contained in the <see cref="List{T}"/> this attribute is attached to.</typeparam>
     public class TypedListConverter<T> : JsonConverter
     {
         private readonly bool requiresTypeVersion;

osu.Game/Overlays/Profile/Sections/Ranks/DrawableProfileScore.cs

@@ -4,7 +4,6 @@
 using OpenTK;
 using osu.Framework.Allocation;
 using osu.Framework.Graphics;
-using osu.Framework.Graphics.Containers;
 using osu.Game.Graphics;
 using osu.Game.Graphics.Sprites;
 using osu.Game.Rulesets.Mods;
@@ -16,7 +15,6 @@ namespace osu.Game.Overlays.Profile.Sections.Ranks
 {
     public abstract class DrawableProfileScore : DrawableProfileRow
     {
-        private readonly FillFlowContainer metadata;
         private readonly ScoreModsContainer modsContainer;
         protected readonly Score Score;
 

osu.Game/Rulesets/Mods/IApplicableToDrawableHitObject.cs

@@ -14,7 +14,7 @@ namespace osu.Game.Rulesets.Mods
         /// <summary>
         /// Applies this <see cref="IApplicableToDrawableHitObjects"/> to a list of <see cref="DrawableHitObject"/>s.
         /// </summary>
-        /// <param name="drawable">The list of <see cref="DrawableHitObject"/>s to apply to.</param>
+        /// <param name="drawables">The list of <see cref="DrawableHitObject"/>s to apply to.</param>
         void ApplyToDrawableHitObjects(IEnumerable<DrawableHitObject> drawables);
     }
 }

osu.Game/Screens/Loader.cs

@@ -101,8 +101,6 @@ namespace osu.Game.Screens
                 loadTargets.Add(manager.Load(VertexShaderDescriptor.TEXTURE_3, FragmentShaderDescriptor.TEXTURE));
             }
 
-            private Shader currentLoadTarget;
-
             protected override void Update()
             {
                 base.Update();

osu.Game/Screens/Select/Carousel/CarouselGroup.cs

@@ -10,8 +10,6 @@ namespace osu.Game.Screens.Select.Carousel
     /// </summary>
     public class CarouselGroup : CarouselItem
     {
-        private readonly List<CarouselItem> items;
-
         protected override DrawableCarouselItem CreateDrawableRepresentation() => null;
 
         public IReadOnlyList<CarouselItem> Children => InternalChildren;

osu.Game/Screens/Select/Carousel/DrawableCarouselBeatmapSet.cs

@@ -31,8 +31,6 @@ namespace osu.Game.Screens.Select.Carousel
 
         private readonly BeatmapSetInfo beatmapSet;
 
-        private readonly FillFlowContainer difficultyIcons;
-
         public DrawableCarouselBeatmapSet(CarouselBeatmapSet set)
             : base(set)
         {

osu.Game/Screens/Select/Leaderboards/RetrievalFailurePlaceholder.cs

@@ -40,7 +40,7 @@ namespace osu.Game.Screens.Select.Leaderboards
         {
             private readonly SpriteIcon icon;
 
-            public Action Action;
+            public new Action Action;
 
             public RetryButton()
             {