mirror of https://github.com/ppy/osu
Fix total score without mods migration failing on custom ruleset scores when custom ruleset cannot be loaded
Closes https://github.com/ppy/osu/issues/28209. Yes this means that such scores will have a zero total score without mods in DB and thus might up getting their total recalculated to zero when we try a mod multiplier rebalance (unless we skip scores with zero completely I suppose). I also don't really care about that right now.
This commit is contained in:
parent
9fcd3b562a
commit
be642c8c42
|
@ -1134,7 +1134,17 @@ void convertOnlineIDs<T>() where T : RealmObject
|
||||||
|
|
||||||
case 41:
|
case 41:
|
||||||
foreach (var score in migration.NewRealm.All<ScoreInfo>())
|
foreach (var score in migration.NewRealm.All<ScoreInfo>())
|
||||||
LegacyScoreDecoder.PopulateTotalScoreWithoutMods(score);
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
// this can fail e.g. if a user has a score set on a ruleset that can no longer be loaded.
|
||||||
|
LegacyScoreDecoder.PopulateTotalScoreWithoutMods(score);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
Logger.Log($@"Failed to populate total score without mods for score {score.ID}: {ex}", LoggingTarget.Database);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue