RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-09 06:36:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Separate storyboard samples and skip intro steps to own methods

Browse Source
This commit is contained in:
Salman Ahmed 2022-03-02 23:55:42 +03:00
parent 82bbc32d74
commit bb94d68139
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
osu.Game.Tests/Visual/Gameplay/TestSceneStoryboardSamplePlayback.cs
View File

@ -51,20 +51,21 @@ namespace osu.Game.Tests.Visual.Gameplay
AddStep("player paused", () => Player.Pause()); AddStep("player paused", () => Player.Pause());
AddAssert("player is currently paused", () => Player.GameplayClockContainer.IsPaused.Value); AddAssert("player is currently paused", () => Player.GameplayClockContainer.IsPaused.Value);
AddAssert("all storyboard samples stopped immediately", () => allStoryboardSamples.All(sound => !sound.IsPlaying)); allStoryobardSamplesStopped();
AddStep("player resume", () => Player.Resume()); AddStep("player resume", () => Player.Resume());
AddUntilStep("any storyboard samples playing after resume", () => allStoryboardSamples.Any(sound => sound.IsPlaying)); waitUntilStoryboardSamplesPlay();
} }
[Test] [Test]
public void TestStoryboardSamplesStopOnSkip() public void TestStoryboardSamplesStopOnSkip()
{ {
createPlayerTest(true); createPlayerTest();
AddAssert("all storyboard samples stopped immediately", () => allStoryboardSamples.All(sound => !sound.IsPlaying)); skipIntro();
allStoryobardSamplesStopped();
AddUntilStep("any storyboard samples playing after skip", () => allStoryboardSamples.Any(sound => sound.IsPlaying)); waitUntilStoryboardSamplesPlay();
} }
[TestCase(typeof(OsuModDoubleTime), 1.5)] [TestCase(typeof(OsuModDoubleTime), 1.5)]
@ -80,7 +81,8 @@ namespace osu.Game.Tests.Visual.Gameplay
storyboardMods = new[] { testedMod }; storyboardMods = new[] { testedMod };
}); });
createPlayerTest(true); createPlayerTest();
skipIntro();
AddAssert("sample playback rate matches mod rates", () => allStoryboardSamples.All(sound => AddAssert("sample playback rate matches mod rates", () => allStoryboardSamples.All(sound =>
sound.ChildrenOfType<DrawableSample>().First().AggregateFrequency.Value == expectedRate)); sound.ChildrenOfType<DrawableSample>().First().AggregateFrequency.Value == expectedRate));
@ -100,7 +102,8 @@ namespace osu.Game.Tests.Visual.Gameplay
storyboardMods = new[] { testedMod }; storyboardMods = new[] { testedMod };
}); });
createPlayerTest(true); createPlayerTest();
skipIntro();
ModTimeRamp gameplayMod = null; ModTimeRamp gameplayMod = null;
@ -114,17 +117,20 @@ namespace osu.Game.Tests.Visual.Gameplay
sound.ChildrenOfType<DrawableSample>().First().AggregateFrequency.Value == gameplayMod.SpeedChange.Value)); sound.ChildrenOfType<DrawableSample>().First().AggregateFrequency.Value == gameplayMod.SpeedChange.Value));
} }
private void createPlayerTest(bool skipIntro = false) private void createPlayerTest()
{ {
CreateTest(null); CreateTest(null);
AddAssert("storyboard loaded", () => Player.Beatmap.Value.Storyboard != null); AddAssert("storyboard loaded", () => Player.Beatmap.Value.Storyboard != null);
AddUntilStep("any storyboard samples playing", () => allStoryboardSamples.Any(sound => sound.IsPlaying)); waitUntilStoryboardSamplesPlay();
if (skipIntro)
AddStep("skip intro", () => InputManager.Key(Key.Space));
} }
private void waitUntilStoryboardSamplesPlay() => AddUntilStep("any storyboard samples playing", () => allStoryboardSamples.Any(sound => sound.IsPlaying));
private void allStoryobardSamplesStopped() => AddAssert("all storyboard samples stopped immediately", () => allStoryboardSamples.All(sound => !sound.IsPlaying));
private void skipIntro() => AddStep("skip intro", () => InputManager.Key(Key.Space));
private IEnumerable<DrawableStoryboardSample> allStoryboardSamples => Player.ChildrenOfType<DrawableStoryboardSample>(); private IEnumerable<DrawableStoryboardSample> allStoryboardSamples => Player.ChildrenOfType<DrawableStoryboardSample>();
protected override bool AllowFail => false; protected override bool AllowFail => false;