RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix code review issues

This commit is contained in:
Dean Herbert 2017-10-12 22:27:22 +09:00
parent d234791bdd
commit bb6b656ec6
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Rulesets.Catch/Objects/Drawable/DrawableFruit.cs
View File

@ -12,14 +12,12 @@ namespace osu.Game.Rulesets.Catch.Objects.Drawable
{ {
public class DrawableFruit : DrawableCatchHitObject<Fruit> public class DrawableFruit : DrawableCatchHitObject<Fruit>
{ {
private const float pulp_size = 20;
public DrawableFruit(Fruit h) public DrawableFruit(Fruit h)
: base(h) : base(h)
{ {
Origin = Anchor.Centre; Origin = Anchor.Centre;
Size = new Vector2(pulp_size * 2.2f, pulp_size * 2.8f); Size = new Vector2(Pulp.PULP_SIZE * 2.2f, Pulp.PULP_SIZE * 2.8f);
AccentColour = HitObject.ComboColour; AccentColour = HitObject.ComboColour;
Masking = false; Masking = false;

2
osu.Game.Rulesets.Catch/Objects/JuiceStream.cs
View File

@ -18,7 +18,7 @@ namespace osu.Game.Rulesets.Catch.Objects
public class JuiceStream : CatchBaseHit, IHasCurve public class JuiceStream : CatchBaseHit, IHasCurve
{ {
/// <summary> /// <summary>
/// Scoring distance with a speed-adjusted beat length of 1 second. /// Positional distance that results in a duration of one second, before any speed adjustments.
/// </summary> /// </summary>
private const float base_scoring_distance = 100; private const float base_scoring_distance = 100;

4
osu.Game/Rulesets/Objects/SliderCurve.cs
View File

@ -15,8 +15,6 @@ public class SliderCurve
public List<Vector2> ControlPoints; public List<Vector2> ControlPoints;
public double Scale = 1;
public CurveType CurveType = CurveType.PerfectCurve; public CurveType CurveType = CurveType.PerfectCurve;
public Vector2 Offset; public Vector2 Offset;
@ -202,4 +200,4 @@ public Vector2 PositionAt(double progress)
return interpolateVertices(indexOfDistance(d), d) + Offset; return interpolateVertices(indexOfDistance(d), d) + Offset;
} }
} }
} }