mirror of
https://github.com/ppy/osu
synced 2024-12-12 09:58:22 +00:00
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
Resolves https://github.com/ppy/osu/issues/25987. Structure is a bit clumsy but I'm not sure how to do better...
This commit is contained in:
parent
7e9d12e1d2
commit
b4e71a0787
@ -50,17 +50,16 @@ namespace osu.Game.Skinning
|
||||
|
||||
// legacy judgements don't play any transforms if they are an animation.... UNLESS they are the temporary displayed judgement from new piece.
|
||||
if (animation?.FrameCount > 1 && !forceTransforms)
|
||||
{
|
||||
if (isMissedTick())
|
||||
applyMissedTickScaling();
|
||||
return;
|
||||
}
|
||||
|
||||
if (result.IsMiss())
|
||||
{
|
||||
bool isTick = result != HitResult.Miss;
|
||||
|
||||
if (isTick)
|
||||
{
|
||||
this.ScaleTo(0.6f);
|
||||
this.ScaleTo(0.3f, 100, Easing.In);
|
||||
}
|
||||
if (isMissedTick())
|
||||
applyMissedTickScaling();
|
||||
else
|
||||
{
|
||||
this.ScaleTo(1.6f);
|
||||
@ -95,6 +94,14 @@ namespace osu.Game.Skinning
|
||||
}
|
||||
}
|
||||
|
||||
private bool isMissedTick() => result.IsMiss() && result != HitResult.Miss;
|
||||
|
||||
private void applyMissedTickScaling()
|
||||
{
|
||||
this.ScaleTo(0.6f);
|
||||
this.ScaleTo(0.3f, 100, Easing.In);
|
||||
}
|
||||
|
||||
public Drawable GetAboveHitObjectsProxiedContent() => CreateProxy();
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user