From b4aa24703239da3b5e81fe834b06fe661662dbfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Fri, 16 Feb 2024 12:59:22 +0100 Subject: [PATCH] Do not attempt to stop watching user presence when requested to disconnect First of all, this sort of cleanup isn't really the client's responsibility, and secondly, at the point the client received this request to disconnect, *none of its requests will be honored anymore* (currently the only scenario of this if another client has connected - the server-side concurrency filter will reject this request). When disconnection is requested, the only valid thing to do with respect to talking to the server is to stop doing it. This will be moved server-side in a follow-up change, although I'm not even strictly sure that's required - I'd like to think signalr would know to clean up a disconnecting client from all groups they were in. --- osu.Game/Online/Metadata/OnlineMetadataClient.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/osu.Game/Online/Metadata/OnlineMetadataClient.cs b/osu.Game/Online/Metadata/OnlineMetadataClient.cs index ea8ef60124..3805d12688 100644 --- a/osu.Game/Online/Metadata/OnlineMetadataClient.cs +++ b/osu.Game/Online/Metadata/OnlineMetadataClient.cs @@ -232,7 +232,6 @@ public override async Task EndWatchingUserPresence() public override async Task DisconnectRequested() { await base.DisconnectRequested().ConfigureAwait(false); - await EndWatchingUserPresence().ConfigureAwait(false); if (connector != null) await connector.Disconnect().ConfigureAwait(false); }