mirror of
https://github.com/ppy/osu
synced 2025-02-01 10:51:53 +00:00
Move Passed
assignment inside FailScore
This commit is contained in:
parent
c1bcbd9c8a
commit
ad09e728fd
@ -461,6 +461,8 @@ namespace osu.Game.Rulesets.Scoring
|
|||||||
if (Rank.Value == ScoreRank.F)
|
if (Rank.Value == ScoreRank.F)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
score.Passed = false;
|
||||||
|
|
||||||
Rank.Value = ScoreRank.F;
|
Rank.Value = ScoreRank.F;
|
||||||
Rank.Disabled = true;
|
Rank.Disabled = true;
|
||||||
|
|
||||||
|
@ -851,7 +851,6 @@ namespace osu.Game.Screens.Play
|
|||||||
// fail completion is a good point to mark a score as failed,
|
// fail completion is a good point to mark a score as failed,
|
||||||
// since the last judgement that caused the fail only applies to score processor after onFail.
|
// since the last judgement that caused the fail only applies to score processor after onFail.
|
||||||
// todo: this should probably be handled better.
|
// todo: this should probably be handled better.
|
||||||
Score.ScoreInfo.Passed = false;
|
|
||||||
ScoreProcessor.FailScore(Score.ScoreInfo);
|
ScoreProcessor.FailScore(Score.ScoreInfo);
|
||||||
|
|
||||||
GameplayClockContainer.Stop();
|
GameplayClockContainer.Stop();
|
||||||
@ -1030,10 +1029,7 @@ namespace osu.Game.Screens.Play
|
|||||||
|
|
||||||
// if arriving here and the results screen preparation task hasn't run, it's safe to say the user has not completed the beatmap.
|
// if arriving here and the results screen preparation task hasn't run, it's safe to say the user has not completed the beatmap.
|
||||||
if (prepareScoreForDisplayTask == null)
|
if (prepareScoreForDisplayTask == null)
|
||||||
{
|
|
||||||
Score.ScoreInfo.Passed = false;
|
|
||||||
ScoreProcessor.FailScore(Score.ScoreInfo);
|
ScoreProcessor.FailScore(Score.ScoreInfo);
|
||||||
}
|
|
||||||
|
|
||||||
// EndPlaying() is typically called from ReplayRecorder.Dispose(). Disposal is currently asynchronous.
|
// EndPlaying() is typically called from ReplayRecorder.Dispose(). Disposal is currently asynchronous.
|
||||||
// To resolve test failures, forcefully end playing synchronously when this screen exits.
|
// To resolve test failures, forcefully end playing synchronously when this screen exits.
|
||||||
|
Loading…
Reference in New Issue
Block a user