RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-20 21:10:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move Passed assignment inside FailScore

Browse Source
This commit is contained in:
Salman Ahmed 2022-07-21 08:12:06 +03:00
parent c1bcbd9c8a
commit ad09e728fd
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Rulesets/Scoring/ScoreProcessor.cs
View File

@ -461,6 +461,8 @@ namespace osu.Game.Rulesets.Scoring
if (Rank.Value == ScoreRank.F)
return;
score.Passed = false;
Rank.Value = ScoreRank.F;
Rank.Disabled = true;

4
osu.Game/Screens/Play/Player.cs
View File

@ -851,7 +851,6 @@ namespace osu.Game.Screens.Play
// fail completion is a good point to mark a score as failed,
// since the last judgement that caused the fail only applies to score processor after onFail.
// todo: this should probably be handled better.
Score.ScoreInfo.Passed = false;
ScoreProcessor.FailScore(Score.ScoreInfo);
GameplayClockContainer.Stop();
@ -1030,10 +1029,7 @@ namespace osu.Game.Screens.Play
// if arriving here and the results screen preparation task hasn't run, it's safe to say the user has not completed the beatmap.
if (prepareScoreForDisplayTask == null)
{
Score.ScoreInfo.Passed = false;
ScoreProcessor.FailScore(Score.ScoreInfo);
}
// EndPlaying() is typically called from ReplayRecorder.Dispose(). Disposal is currently asynchronous.
// To resolve test failures, forcefully end playing synchronously when this screen exits.