RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-03-03 01:49:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add logging for various cases of SongSelect.FinaliseSelection being aborted

Browse Source
This commit is contained in:
Dean Herbert 2022-06-27 20:10:15 +09:00
parent f355c3a3c9
commit aa7d54f8b6
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSongSelect.cs
View File

@ -6,6 +6,7 @@ using System.Linq;
using System.Threading.Tasks; using System.Threading.Tasks;
using osu.Framework.Allocation; using osu.Framework.Allocation;
using osu.Framework.Bindables; using osu.Framework.Bindables;
using osu.Framework.Logging;
using osu.Framework.Screens; using osu.Framework.Screens;
using osu.Game.Beatmaps; using osu.Game.Beatmaps;
using osu.Game.Graphics.UserInterface; using osu.Game.Graphics.UserInterface;
@ -78,7 +79,10 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer
protected override bool SelectItem(PlaylistItem item) protected override bool SelectItem(PlaylistItem item)
{ {
if (operationInProgress.Value) if (operationInProgress.Value)
{
Logger.Log($"{nameof(SelectedItem)} aborted due to {nameof(operationInProgress)}");
return false; return false;
}
// If the client is already in a room, update via the client. // If the client is already in a room, update via the client.
// Otherwise, update the playlist directly in preparation for it to be submitted to the API on match creation. // Otherwise, update the playlist directly in preparation for it to be submitted to the API on match creation.

3
osu.Game/Screens/Select/SongSelect.cs
View File

@ -360,7 +360,10 @@ namespace osu.Game.Screens.Select
{ {
// This is very important as we have not yet bound to screen-level bindables before the carousel load is completed. // This is very important as we have not yet bound to screen-level bindables before the carousel load is completed.
if (!Carousel.BeatmapSetsLoaded) if (!Carousel.BeatmapSetsLoaded)
{
Logger.Log($"{nameof(FinaliseSelection)} aborted as carousel beatmaps are not yet loaded");
return; return;
}
if (ruleset != null) if (ruleset != null)
Ruleset.Value = ruleset; Ruleset.Value = ruleset;