RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add back `null` beatmap allowance to `GetTotalScore` flow to fix playlist aggregate scores

This commit is contained in:
Dean Herbert 2022-01-17 13:11:43 +09:00
parent 88bf406c22
commit a3806f44a5
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Scoring/ScoreManager.cs
View File

@ -132,9 +132,10 @@ public void GetTotalScore([NotNull] ScoreInfo score, [NotNull] Action<long> call
/// <returns>The total score.</returns>
public async Task<long> GetTotalScoreAsync([NotNull] ScoreInfo score, ScoringMode mode = ScoringMode.Standardised, CancellationToken cancellationToken = default)
{
// TODO: ??
// if (score.Beatmap == null)
// return score.TotalScore;
// TODO: This is required for playlist aggregate scores. They should likely not be getting here in the first place.
// ReSharper disable once ConditionIsAlwaysTrueOrFalse
if (score.BeatmapInfo == null)
return score.TotalScore;
int beatmapMaxCombo;
double accuracy = score.Accuracy;