RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove redundant storage of blueprint's related item

This commit is contained in:
Dean Herbert 2021-05-03 15:18:18 +09:00
parent df8609b3dc
commit a298a93070
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Skinning/Editor/SkinBlueprint.cs
View File

@ -9,7 +9,6 @@
using osu.Game.Graphics; using osu.Game.Graphics;
using osu.Game.Graphics.UserInterface; using osu.Game.Graphics.UserInterface;
using osu.Game.Rulesets.Edit; using osu.Game.Rulesets.Edit;
using osu.Game.Rulesets.Objects.Drawables;
using osu.Game.Screens.Play.HUD; using osu.Game.Screens.Play.HUD;
using osuTK; using osuTK;
@ -17,26 +16,20 @@ namespace osu.Game.Skinning.Editor
{ {
public class SkinBlueprint : SelectionBlueprint<ISkinnableComponent> public class SkinBlueprint : SelectionBlueprint<ISkinnableComponent>
{ {
/// <summary>
/// The <see cref="DrawableHitObject"/> which this <see cref="OverlaySelectionBlueprint"/> applies to.
/// </summary>
public readonly ISkinnableComponent Component;
private Container box; private Container box;
private Drawable drawable => (Drawable)Component; private Drawable drawable => (Drawable)Item;
/// <summary> /// <summary>
/// Whether the blueprint should be shown even when the <see cref="Component"/> is not alive. /// Whether the blueprint should be shown even when the <see cref="SelectionBlueprint{T}.Item"/> is not alive.
/// </summary> /// </summary>
protected virtual bool AlwaysShowWhenSelected => false; protected virtual bool AlwaysShowWhenSelected => false;
protected override bool ShouldBeAlive => (drawable.IsAlive && Component.IsPresent) || (AlwaysShowWhenSelected && State == SelectionState.Selected); protected override bool ShouldBeAlive => (drawable.IsAlive && Item.IsPresent) || (AlwaysShowWhenSelected && State == SelectionState.Selected);
public SkinBlueprint(ISkinnableComponent component) public SkinBlueprint(ISkinnableComponent component)
: base(component) : base(component)
{ {
Component = component;
} }
[BackgroundDependencyLoader] [BackgroundDependencyLoader]