From a2501cc81de4aa45bbf687a72acafaf071e8e42a Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Tue, 24 Jan 2017 18:09:45 +0900 Subject: [PATCH] Fix TestCaseHitObjects not working at all due to state being set before load is complete. --- osu.Desktop.VisualTests/Tests/TestCaseHitObjects.cs | 1 - osu.Game/Modes/Objects/Drawables/DrawableHitObject.cs | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/osu.Desktop.VisualTests/Tests/TestCaseHitObjects.cs b/osu.Desktop.VisualTests/Tests/TestCaseHitObjects.cs index 59ef75a909..18d8dcc814 100644 --- a/osu.Desktop.VisualTests/Tests/TestCaseHitObjects.cs +++ b/osu.Desktop.VisualTests/Tests/TestCaseHitObjects.cs @@ -49,7 +49,6 @@ public override void Reset() DrawableHitCircle d = new DrawableHitCircle(h) { Anchor = Anchor.Centre, - Origin = Anchor.Centre, Depth = i, State = ArmedState.Hit, Judgement = new OsuJudgementInfo { Result = HitResult.Hit } diff --git a/osu.Game/Modes/Objects/Drawables/DrawableHitObject.cs b/osu.Game/Modes/Objects/Drawables/DrawableHitObject.cs index 58f39013a8..f2dc7268ac 100644 --- a/osu.Game/Modes/Objects/Drawables/DrawableHitObject.cs +++ b/osu.Game/Modes/Objects/Drawables/DrawableHitObject.cs @@ -43,8 +43,8 @@ public ArmedState State state = value; UpdateState(state); - - Expire(); + if (IsLoaded) + Expire(); if (State == ArmedState.Hit) PlaySample();