RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Actually use bindables rather than stick things in `Update()`

This commit is contained in:
Bartłomiej Dach 2024-09-24 15:15:28 +02:00
parent 4f57a67ea4
commit 9f4e48dde7
No known key found for this signature in database
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Screens/Play/HUD/ArgonSongProgress.cs
View File

@ -98,6 +98,7 @@ protected override void LoadComplete()
Interactive.BindValueChanged(_ => bar.Interactive = Interactive.Value, true);
ShowGraph.BindValueChanged(_ => updateGraphVisibility(), true);
ShowTime.BindValueChanged(_ => info.FadeTo(ShowTime.Value ? 1 : 0, 200, Easing.In), true);
AccentColour.BindValueChanged(_ => Colour = AccentColour.Value, true);
}
protected override void UpdateObjects(IEnumerable<HitObject> objects)
@ -118,7 +119,6 @@ protected override void Update()
base.Update();
content.Height = bar.Height + bar_height + info.Height;
graphContainer.Height = bar.Height;
Colour = AccentColour.Value;
}
protected override void UpdateProgress(double progress, bool isIntro)

3
osu.Game/Screens/Play/HUD/DefaultSongProgress.cs
View File

@ -90,6 +90,7 @@ protected override void LoadComplete()
Interactive.BindValueChanged(_ => updateBarVisibility(), true);
ShowGraph.BindValueChanged(_ => updateGraphVisibility(), true);
ShowTime.BindValueChanged(_ => updateTimeVisibility(), true);
AccentColour.BindValueChanged(_ => Colour = AccentColour.Value, true);
base.LoadComplete();
}
@ -118,8 +119,6 @@ protected override void Update()
if (!Precision.AlmostEquals(Height, newHeight, 5f))
content.Height = newHeight;
Colour = AccentColour.Value;
}
private void updateBarVisibility()

8
osu.Game/Skinning/Components/BoxElement.cs
View File

@ -46,12 +46,18 @@ public BoxElement()
Masking = true;
}
protected override void LoadComplete()
{
base.LoadComplete();
AccentColour.BindValueChanged(_ => Colour = AccentColour.Value, true);
}
protected override void Update()
{
base.Update();
base.CornerRadius = CornerRadius.Value * Math.Min(DrawWidth, DrawHeight);
Colour = AccentColour.Value;
}
}
}