From 9d457535c630d2d1cc8bee08f005e77f42052d0c Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 29 Jul 2022 16:22:54 +0900
Subject: [PATCH] Add confirmation dialog when about to discard a playlist

The confirmation will only show if items have been added to the
playlist.

Closes https://github.com/ppy/osu/issues/19444.
---
 .../Menu/ConfirmDiscardChangesDialog.cs       | 39 +++++++++++++++++++
 osu.Game/Screens/Menu/ConfirmExitDialog.cs    |  4 +-
 .../Screens/OnlinePlay/Match/RoomSubScreen.cs | 24 ++++++++++--
 3 files changed, 61 insertions(+), 6 deletions(-)
 create mode 100644 osu.Game/Screens/Menu/ConfirmDiscardChangesDialog.cs

diff --git a/osu.Game/Screens/Menu/ConfirmDiscardChangesDialog.cs b/osu.Game/Screens/Menu/ConfirmDiscardChangesDialog.cs
new file mode 100644
index 0000000000..450c559450
--- /dev/null
+++ b/osu.Game/Screens/Menu/ConfirmDiscardChangesDialog.cs
@@ -0,0 +1,39 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System;
+using osu.Framework.Graphics.Sprites;
+using osu.Game.Overlays.Dialog;
+
+namespace osu.Game.Screens.Menu
+{
+    public class ConfirmDiscardChangesDialog : PopupDialog
+    {
+        /// <summary>
+        /// Construct a new discard changes confirmation dialog.
+        /// </summary>
+        /// <param name="onConfirm">An action to perform on confirmation.</param>
+        /// <param name="onCancel">An optional action to perform on cancel.</param>
+        public ConfirmDiscardChangesDialog(Action onConfirm, Action? onCancel = null)
+        {
+            HeaderText = "Are you sure you want to go back?";
+            BodyText = "This will discard any unsaved changes";
+
+            Icon = FontAwesome.Solid.ExclamationTriangle;
+
+            Buttons = new PopupDialogButton[]
+            {
+                new PopupDialogDangerousButton
+                {
+                    Text = @"Yes",
+                    Action = onConfirm
+                },
+                new PopupDialogCancelButton
+                {
+                    Text = @"No I didn't mean to",
+                    Action = onCancel
+                },
+            };
+        }
+    }
+}
diff --git a/osu.Game/Screens/Menu/ConfirmExitDialog.cs b/osu.Game/Screens/Menu/ConfirmExitDialog.cs
index 734ff6b23f..20fa889986 100644
--- a/osu.Game/Screens/Menu/ConfirmExitDialog.cs
+++ b/osu.Game/Screens/Menu/ConfirmExitDialog.cs
@@ -1,8 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-#nullable disable
-
 using System;
 using osu.Framework.Graphics.Sprites;
 using osu.Game.Overlays.Dialog;
@@ -16,7 +14,7 @@ public class ConfirmExitDialog : PopupDialog
         /// </summary>
         /// <param name="onConfirm">An action to perform on confirmation.</param>
         /// <param name="onCancel">An optional action to perform on cancel.</param>
-        public ConfirmExitDialog(Action onConfirm, Action onCancel = null)
+        public ConfirmExitDialog(Action onConfirm, Action? onCancel = null)
         {
             HeaderText = "Are you sure you want to exit osu!?";
             BodyText = "Last chance to turn back";
diff --git a/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs b/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs
index f5af110372..5b3ed0059d 100644
--- a/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs
+++ b/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs
@@ -28,6 +28,7 @@
 using osu.Game.Overlays.Mods;
 using osu.Game.Rulesets;
 using osu.Game.Rulesets.Mods;
+using osu.Game.Screens.Menu;
 using osu.Game.Screens.OnlinePlay.Match.Components;
 using osu.Game.Screens.OnlinePlay.Multiplayer;
 
@@ -280,13 +281,30 @@ protected override IReadOnlyDependencyContainer CreateChildDependencies(IReadOnl
             };
         }
 
+        [Resolved(canBeNull: true)]
+        private IDialogOverlay dialogOverlay { get; set; }
+
         public override bool OnBackButton()
         {
             if (Room.RoomID.Value == null)
             {
-                // room has not been created yet; exit immediately.
-                settingsOverlay.Hide();
-                return base.OnBackButton();
+                if (dialogOverlay == null || Room.Playlist.Count == 0)
+                {
+                    settingsOverlay.Hide();
+                    return base.OnBackButton();
+                }
+
+                // if the dialog is already displayed, block exiting until the user explicitly makes a decision.
+                if (dialogOverlay.CurrentDialog is ConfirmDiscardChangesDialog)
+                    return true;
+
+                dialogOverlay?.Push(new ConfirmDiscardChangesDialog(() =>
+                {
+                    settingsOverlay.Hide();
+                    this.Exit();
+                }));
+
+                return true;
             }
 
             if (UserModsSelectOverlay.State.Value == Visibility.Visible)