RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-15 11:25:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #26721 from EVAST9919/all-judged-no-alloc

Browse Source 
Reduce allocation overhead in `SliderInputManager.updateTracking`
This commit is contained in:
Dean Herbert 2024-01-26 18:17:14 +09:00 committed by GitHub
commit 9aa637f791
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
osu.Game.Rulesets.Osu/Objects/Drawables/SliderInputManager.cs
View File

@ -215,8 +215,6 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
if (headCircleHitAction == null)
timeToAcceptAnyKeyAfter = null;
var actions = slider.OsuActionInputManager?.PressedActions;
// if the head circle was hit with a specific key, tracking should only occur while that key is pressed.
if (headCircleHitAction != null && timeToAcceptAnyKeyAfter == null)
{
@ -227,6 +225,20 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
timeToAcceptAnyKeyAfter = Time.Current;
}
if (slider.OsuActionInputManager == null)
return;
lastPressedActions.Clear();
bool validTrackingAction = false;
foreach (OsuAction action in slider.OsuActionInputManager.PressedActions)
{
if (isValidTrackingAction(action))
validTrackingAction = true;
lastPressedActions.Add(action);
}
Tracking =
// even in an edge case where current time has exceeded the slider's time, we may not have finished judging.
// we don't want to potentially update from Tracking=true to Tracking=false at this point.
@ -234,11 +246,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
// in valid position range
&& isValidTrackingPosition
// valid action
&& (actions?.Any(isValidTrackingAction) ?? false);
lastPressedActions.Clear();
if (actions != null)
lastPressedActions.AddRange(actions);
&& validTrackingAction;
}
private OsuAction? getInitialHitAction() => slider.HeadCircle?.HitAction;