From 8f3215f5a0b251f29e4863e50b396e91624e33e3 Mon Sep 17 00:00:00 2001
From: smoogipoo <smoogipoo@smgi.me>
Date: Mon, 11 Jun 2018 20:42:04 +0900
Subject: [PATCH 1/2] Make sure taiko hitexplosions expire and get removed
---
osu.Game.Rulesets.Taiko/UI/HitExplosion.cs | 4 +++-
osu.Game.Rulesets.Taiko/UI/KiaiHitExplosion.cs | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/osu.Game.Rulesets.Taiko/UI/HitExplosion.cs b/osu.Game.Rulesets.Taiko/UI/HitExplosion.cs
index ee2c1d5ad5..4dd0ba4d3d 100644
--- a/osu.Game.Rulesets.Taiko/UI/HitExplosion.cs
+++ b/osu.Game.Rulesets.Taiko/UI/HitExplosion.cs
@@ -18,6 +18,8 @@ namespace osu.Game.Rulesets.Taiko.UI
/// </summary>
internal class HitExplosion : CircularContainer
{
+ public override bool RemoveWhenNotAlive => true;
+
public readonly DrawableHitObject JudgedObject;
private readonly Box innerFill;
@@ -66,7 +68,7 @@ namespace osu.Game.Rulesets.Taiko.UI
this.ScaleTo(3f, 1000, Easing.OutQuint);
this.FadeOut(500);
- Expire();
+ Expire(true);
}
/// <summary>
diff --git a/osu.Game.Rulesets.Taiko/UI/KiaiHitExplosion.cs b/osu.Game.Rulesets.Taiko/UI/KiaiHitExplosion.cs
index ac3cf8305a..287d59972a 100644
--- a/osu.Game.Rulesets.Taiko/UI/KiaiHitExplosion.cs
+++ b/osu.Game.Rulesets.Taiko/UI/KiaiHitExplosion.cs
@@ -14,6 +14,8 @@ namespace osu.Game.Rulesets.Taiko.UI
{
public class KiaiHitExplosion : CircularContainer
{
+ public override bool RemoveWhenNotAlive => true;
+
public readonly DrawableHitObject JudgedObject;
private readonly bool isRim;
@@ -62,7 +64,7 @@ namespace osu.Game.Rulesets.Taiko.UI
this.ScaleTo(new Vector2(1, 3f), 500, Easing.OutQuint);
this.FadeOut(250);
- Expire();
+ Expire(true);
}
}
}
From 7651819fb0ea29f7f636cdd4e4e42fcfa680e24b Mon Sep 17 00:00:00 2001
From: smoogipoo <smoogipoo@smgi.me>
Date: Tue, 12 Jun 2018 12:53:53 +0900
Subject: [PATCH 2/2] Add same change to mania's hit explosions
---
osu.Game.Rulesets.Mania/UI/HitExplosion.cs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/osu.Game.Rulesets.Mania/UI/HitExplosion.cs b/osu.Game.Rulesets.Mania/UI/HitExplosion.cs
index f19c3a811b..bf8db63137 100644
--- a/osu.Game.Rulesets.Mania/UI/HitExplosion.cs
+++ b/osu.Game.Rulesets.Mania/UI/HitExplosion.cs
@@ -15,6 +15,8 @@ namespace osu.Game.Rulesets.Mania.UI
{
internal class HitExplosion : CompositeDrawable
{
+ public override bool RemoveWhenNotAlive => true;
+
private readonly CircularContainer circle;
public HitExplosion(DrawableHitObject judgedObject)