RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix regression causing hard crash 

Regressed in #2373. My bad.
This commit is contained in:
Dean Herbert 2018-04-11 19:24:19 +09:00
parent 9e5e2c8863
commit 903dd7a015
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game/Overlays/Settings/Sections/SkinSection.cs
View File

@ -51,15 +51,17 @@ private void load(OsuConfigManager config, SkinManager skins)
},
};
skins.ItemAdded += reloadSkins;
skins.ItemRemoved += reloadSkins;
skins.ItemAdded += onItemsChanged;
skins.ItemRemoved += onItemsChanged;
reloadSkins(null);
reloadSkins();
skinDropdown.Bindable = config.GetBindable<int>(OsuSetting.Skin);
}
private void reloadSkins(SkinInfo changed) => Schedule(() => skinDropdown.Items = skins.GetAllUsableSkins().Select(s => new KeyValuePair<string, int>(s.ToString(), s.ID)));
private void reloadSkins() => skinDropdown.Items = skins.GetAllUsableSkins().Select(s => new KeyValuePair<string, int>(s.ToString(), s.ID));
private void onItemsChanged(SkinInfo _) => Schedule(reloadSkins);
protected override void Dispose(bool isDisposing)
{
@ -67,8 +69,8 @@ protected override void Dispose(bool isDisposing)
if (skins != null)
{
skins.ItemAdded -= reloadSkins;
skins.ItemRemoved -= reloadSkins;
skins.ItemAdded -= onItemsChanged;
skins.ItemRemoved -= onItemsChanged;
}
}