From 8f698a42f727472723668931713ae4671af2ace0 Mon Sep 17 00:00:00 2001
From: Opelkuh <25430283+Opelkuh@users.noreply.github.com>
Date: Sun, 15 Aug 2021 20:35:52 +0200
Subject: [PATCH] Refactor `MarkChannelAsRead` test assert

---
 .../Chat/TestSceneChannelManager.cs           | 75 +++++++++----------
 1 file changed, 35 insertions(+), 40 deletions(-)

diff --git a/osu.Game.Tests/Chat/TestSceneChannelManager.cs b/osu.Game.Tests/Chat/TestSceneChannelManager.cs
index fcb602cb04..5e22101e5c 100644
--- a/osu.Game.Tests/Chat/TestSceneChannelManager.cs
+++ b/osu.Game.Tests/Chat/TestSceneChannelManager.cs
@@ -47,19 +47,11 @@ public void SetUpSteps()
                             return true;
 
                         case PostMessageRequest postMessage:
-                            var message = new Message(++currentMessageId)
-                            {
-                                IsAction = postMessage.Message.IsAction,
-                                ChannelId = postMessage.Message.ChannelId,
-                                Content = postMessage.Message.Content,
-                                Links = postMessage.Message.Links,
-                                Timestamp = postMessage.Message.Timestamp,
-                                Sender = postMessage.Message.Sender
-                            };
-
-                            sentMessages.Add(message);
-                            postMessage.TriggerSuccess(message);
+                            handlePostMessageRequest(postMessage);
+                            return true;
 
+                        case MarkChannelAsReadRequest markRead:
+                            handleMarkChannelAsReadRequest(markRead);
                             return true;
                     }
 
@@ -101,41 +93,44 @@ public void TestMarkAsReadIgnoringLocalMessages()
             });
 
             AddStep("post message", () => channelManager.PostMessage("Something interesting"));
-            AddUntilStep("wait until the message is posted", () => channel.Messages.Count == sentMessages.Count);
+
             AddStep("post /help command", () => channelManager.PostCommand("help", channel));
             AddStep("post /me command with no action", () => channelManager.PostCommand("me", channel));
             AddStep("post /join command with no channel", () => channelManager.PostCommand("join", channel));
             AddStep("post /join command with non-existent channel", () => channelManager.PostCommand("join i-dont-exist", channel));
             AddStep("post non-existent command", () => channelManager.PostCommand("non-existent-cmd arg", channel));
 
-            AddStep("register mark channel as read request handler", () =>
-            {
-                ((DummyAPIAccess)API).HandleRequest = req =>
-                {
-                    switch (req)
-                    {
-                        case MarkChannelAsReadRequest markRead:
-                            var isSentMessage = sentMessages.Contains(markRead.Message);
-
-                            AddAssert("mark channel as read called with a real message", () => isSentMessage);
-
-                            if (isSentMessage)
-                            {
-                                markRead.TriggerSuccess();
-                            }
-                            else
-                            {
-                                markRead.TriggerFailure(new APIException("unknown message!", null));
-                            }
-
-                            return true;
-                    }
-
-                    return false;
-                };
-            });
-
             AddStep("mark channel as read", () => channelManager.MarkChannelAsRead(channel));
+            AddAssert("channel's last read ID is set to the latest message", () => channel.LastReadId == sentMessages.Last().Id);
+        }
+
+        private void handlePostMessageRequest(PostMessageRequest request)
+        {
+            var message = new Message(++currentMessageId)
+            {
+                IsAction = request.Message.IsAction,
+                ChannelId = request.Message.ChannelId,
+                Content = request.Message.Content,
+                Links = request.Message.Links,
+                Timestamp = request.Message.Timestamp,
+                Sender = request.Message.Sender
+            };
+
+            sentMessages.Add(message);
+            request.TriggerSuccess(message);
+        }
+
+        private void handleMarkChannelAsReadRequest(MarkChannelAsReadRequest request)
+        {
+            // only accept messages that were sent through the API
+            if (sentMessages.Contains(request.Message))
+            {
+                request.TriggerSuccess();
+            }
+            else
+            {
+                request.TriggerFailure(new APIException("unknown message!", null));
+            }
         }
 
         private Channel createChannel(int id, ChannelType type) => new Channel(new User())