RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor `MarkChannelAsRead` test assert

This commit is contained in:
Opelkuh 2021-08-15 20:35:52 +02:00
parent 7d7c5c06f0
commit 8f698a42f7
1 changed files with 35 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
osu.Game.Tests/Chat/TestSceneChannelManager.cs
View File

@ -47,19 +47,11 @@ public void SetUpSteps()
return true;
case PostMessageRequest postMessage:
var message = new Message(++currentMessageId)
{
IsAction = postMessage.Message.IsAction,
ChannelId = postMessage.Message.ChannelId,
Content = postMessage.Message.Content,
Links = postMessage.Message.Links,
Timestamp = postMessage.Message.Timestamp,
Sender = postMessage.Message.Sender
};
sentMessages.Add(message);
postMessage.TriggerSuccess(message);
handlePostMessageRequest(postMessage);
return true;
case MarkChannelAsReadRequest markRead:
handleMarkChannelAsReadRequest(markRead);
return true;
}
@ -101,41 +93,44 @@ public void TestMarkAsReadIgnoringLocalMessages()
});
AddStep("post message", () => channelManager.PostMessage("Something interesting"));
AddUntilStep("wait until the message is posted", () => channel.Messages.Count == sentMessages.Count);
AddStep("post /help command", () => channelManager.PostCommand("help", channel));
AddStep("post /me command with no action", () => channelManager.PostCommand("me", channel));
AddStep("post /join command with no channel", () => channelManager.PostCommand("join", channel));
AddStep("post /join command with non-existent channel", () => channelManager.PostCommand("join i-dont-exist", channel));
AddStep("post non-existent command", () => channelManager.PostCommand("non-existent-cmd arg", channel));
AddStep("register mark channel as read request handler", () =>
{
((DummyAPIAccess)API).HandleRequest = req =>
{
switch (req)
{
case MarkChannelAsReadRequest markRead:
var isSentMessage = sentMessages.Contains(markRead.Message);
AddAssert("mark channel as read called with a real message", () => isSentMessage);
if (isSentMessage)
{
markRead.TriggerSuccess();
}
else
{
markRead.TriggerFailure(new APIException("unknown message!", null));
}
return true;
}
return false;
};
});
AddStep("mark channel as read", () => channelManager.MarkChannelAsRead(channel));
AddAssert("channel's last read ID is set to the latest message", () => channel.LastReadId == sentMessages.Last().Id);
}
private void handlePostMessageRequest(PostMessageRequest request)
{
var message = new Message(++currentMessageId)
{
IsAction = request.Message.IsAction,
ChannelId = request.Message.ChannelId,
Content = request.Message.Content,
Links = request.Message.Links,
Timestamp = request.Message.Timestamp,
Sender = request.Message.Sender
};
sentMessages.Add(message);
request.TriggerSuccess(message);
}
private void handleMarkChannelAsReadRequest(MarkChannelAsReadRequest request)
{
// only accept messages that were sent through the API
if (sentMessages.Contains(request.Message))
{
request.TriggerSuccess();
}
else
{
request.TriggerFailure(new APIException("unknown message!", null));
}
}
private Channel createChannel(int id, ChannelType type) => new Channel(new User())