From 8955d5de044e4ed5039608fff87b2aa08b5bb25e Mon Sep 17 00:00:00 2001
From: ekrctb <ekrctb@gmail.com>
Date: Tue, 29 Jan 2019 15:25:27 +0900
Subject: [PATCH] Update hit object result when lifetime is end

---
 .../Rulesets/Objects/Drawables/DrawableHitObject.cs    | 10 ++++++++++
 osu.Game/Rulesets/UI/HitObjectContainer.cs             |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs b/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
index 06fe22a95e..62c43a0851 100644
--- a/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
+++ b/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
@@ -220,6 +220,16 @@ namespace osu.Game.Rulesets.Objects.Drawables
             OnNewResult?.Invoke(this, Result);
         }
 
+        /// <summary>
+        /// Should be called at least once after lifetime of this hit object is end.
+        /// </summary>
+        public void OnLifetimeEnd()
+        {
+            foreach (var nested in NestedHitObjects)
+                nested.OnLifetimeEnd();
+            UpdateResult(false);
+        }
+
         /// <summary>
         /// Processes this <see cref="DrawableHitObject"/>, checking if a scoring result has occurred.
         /// </summary>
diff --git a/osu.Game/Rulesets/UI/HitObjectContainer.cs b/osu.Game/Rulesets/UI/HitObjectContainer.cs
index 00632b3d3e..2f3a384e95 100644
--- a/osu.Game/Rulesets/UI/HitObjectContainer.cs
+++ b/osu.Game/Rulesets/UI/HitObjectContainer.cs
@@ -31,5 +31,11 @@ namespace osu.Game.Rulesets.UI
             int i = yObj.HitObject.StartTime.CompareTo(xObj.HitObject.StartTime);
             return i == 0 ? CompareReverseChildID(x, y) : i;
         }
+
+        protected override void OnChildLifetimeBoundaryCrossed(LifetimeBoundaryCrossedEvent e)
+        {
+            if (e.Kind == LifetimeBoundaryKind.End && e.Direction == LifetimeBoundaryCrossingDirection.Forward && e.Child is DrawableHitObject hitObject)
+                hitObject.OnLifetimeEnd();
+        }
     }
 }