From 892f43da433a96d408f8b8d723d03c677d1d3653 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 29 Aug 2022 14:28:55 +0900
Subject: [PATCH] Add test coverage of ruleset being marked unavailable if
 methods are throwing

---
 osu.Game.Tests/Database/RulesetStoreTests.cs | 35 +++++++++++++++++---
 1 file changed, 30 insertions(+), 5 deletions(-)

diff --git a/osu.Game.Tests/Database/RulesetStoreTests.cs b/osu.Game.Tests/Database/RulesetStoreTests.cs
index dedec6dc83..a5662fa121 100644
--- a/osu.Game.Tests/Database/RulesetStoreTests.cs
+++ b/osu.Game.Tests/Database/RulesetStoreTests.cs
@@ -60,15 +60,40 @@ public void TestRetrievedRulesetsAreDetached()
             });
         }
 
+        [Test]
+        public void TestRulesetThrowingOnMethods()
+        {
+            RunTestWithRealm((realm, storage) =>
+            {
+                LoadTestRuleset.Version = Ruleset.CURRENT_RULESET_API_VERSION;
+                LoadTestRuleset.HasImplementations = false;
+
+                var ruleset = new LoadTestRuleset();
+                string rulesetShortName = ruleset.RulesetInfo.ShortName;
+
+                realm.Write(r => r.Add(new RulesetInfo(rulesetShortName, ruleset.RulesetInfo.Name, ruleset.RulesetInfo.InstantiationInfo, ruleset.RulesetInfo.OnlineID)
+                {
+                    Available = true,
+                }));
+
+                Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.True);
+
+                // Availability is updated on construction of a RealmRulesetStore
+                var _ = new RealmRulesetStore(realm, storage);
+
+                Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.False);
+            });
+        }
+
         [Test]
         public void TestOutdatedRulesetNotAvailable()
         {
             RunTestWithRealm((realm, storage) =>
             {
-                OutdatedRuleset.Version = "2021.101.0";
-                OutdatedRuleset.HasImplementations = true;
+                LoadTestRuleset.Version = "2021.101.0";
+                LoadTestRuleset.HasImplementations = true;
 
-                var ruleset = new OutdatedRuleset();
+                var ruleset = new LoadTestRuleset();
                 string rulesetShortName = ruleset.RulesetInfo.ShortName;
 
                 realm.Write(r => r.Add(new RulesetInfo(rulesetShortName, ruleset.RulesetInfo.Name, ruleset.RulesetInfo.InstantiationInfo, ruleset.RulesetInfo.OnlineID)
@@ -84,14 +109,14 @@ public void TestOutdatedRulesetNotAvailable()
                 Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.False);
 
                 // Simulate the ruleset getting updated
-                OutdatedRuleset.Version = Ruleset.CURRENT_RULESET_API_VERSION;
+                LoadTestRuleset.Version = Ruleset.CURRENT_RULESET_API_VERSION;
                 var __ = new RealmRulesetStore(realm, storage);
 
                 Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.True);
             });
         }
 
-        private class OutdatedRuleset : Ruleset
+        private class LoadTestRuleset : Ruleset
         {
             public override string RulesetAPIVersionSupported => Version;