RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use existing reflection methods to avoid manual binding of `ExtendedLimits`

This commit is contained in:
Dean Herbert 2021-07-08 17:00:55 +09:00
parent bd7c334588
commit 88b00123f6
3 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Rulesets.Catch/Mods/CatchModDifficultyAdjust.cs
View File

@ -35,12 +35,6 @@ public class CatchModDifficultyAdjust : ModDifficultyAdjust, IApplicableToBeatma
[SettingSource("Spicy Patterns", "Adjust the patterns as if Hard Rock is enabled.")] [SettingSource("Spicy Patterns", "Adjust the patterns as if Hard Rock is enabled.")]
public BindableBool HardRockOffsets { get; } = new BindableBool(); public BindableBool HardRockOffsets { get; } = new BindableBool();
public CatchModDifficultyAdjust()
{
CircleSize.ExtendedLimits.BindTo(ExtendedLimits);
ApproachRate.ExtendedLimits.BindTo(ExtendedLimits);
}
public override string SettingDescription public override string SettingDescription
{ {
get get

6
osu.Game.Rulesets.Osu/Mods/OsuModDifficultyAdjust.cs
View File

@ -30,12 +30,6 @@ public class OsuModDifficultyAdjust : ModDifficultyAdjust
ReadFromDifficulty = diff => diff.ApproachRate, ReadFromDifficulty = diff => diff.ApproachRate,
}; };
public OsuModDifficultyAdjust()
{
CircleSize.ExtendedLimits.BindTo(ExtendedLimits);
ApproachRate.ExtendedLimits.BindTo(ExtendedLimits);
}
public override string SettingDescription public override string SettingDescription
{ {
get get

7
osu.Game/Rulesets/Mods/ModDifficultyAdjust.cs
View File

@ -57,8 +57,11 @@ public abstract class ModDifficultyAdjust : Mod, IApplicableToDifficulty
protected ModDifficultyAdjust() protected ModDifficultyAdjust()
{ {
OverallDifficulty.ExtendedLimits.BindTo(ExtendedLimits); foreach (var (_, property) in this.GetOrderedSettingsSourceProperties())
DrainRate.ExtendedLimits.BindTo(ExtendedLimits); {
if (property.GetValue(this) is DifficultyBindable diffAdjustBindable)
diffAdjustBindable.ExtendedLimits.BindTo(ExtendedLimits);
}
} }
public override string SettingDescription public override string SettingDescription