From 8745c2f0163760942e573ddae4c940c20c2b67aa Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 7 Nov 2022 16:31:06 +0900
Subject: [PATCH] Split out taiko `DefaultJudgementPiece` and move animations
 across

---
 .../Skinning/Default/DefaultJudgementPiece.cs | 32 +++++++++++++++++++
 .../UI/DrawableTaikoJudgement.cs              | 28 ++--------------
 2 files changed, 34 insertions(+), 26 deletions(-)
 create mode 100644 osu.Game.Rulesets.Taiko/Skinning/Default/DefaultJudgementPiece.cs

diff --git a/osu.Game.Rulesets.Taiko/Skinning/Default/DefaultJudgementPiece.cs b/osu.Game.Rulesets.Taiko/Skinning/Default/DefaultJudgementPiece.cs
new file mode 100644
index 0000000000..a8cead6877
--- /dev/null
+++ b/osu.Game.Rulesets.Taiko/Skinning/Default/DefaultJudgementPiece.cs
@@ -0,0 +1,32 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Graphics;
+using osu.Game.Rulesets.Scoring;
+
+namespace osu.Game.Rulesets.Taiko.Skinning.Default
+{
+    public class DefaultJudgementPiece : Rulesets.Judgements.DefaultJudgementPiece
+    {
+        public DefaultJudgementPiece(HitResult result)
+            : base(result)
+        {
+        }
+
+        public override void PlayAnimation()
+        {
+            if (Result != HitResult.Miss)
+            {
+                this
+                    .MoveToY(0)
+                    .MoveToY(-100, 500);
+
+                JudgementText
+                    .ScaleTo(0.9f)
+                    .ScaleTo(1, 500, Easing.OutElastic);
+            }
+
+            base.PlayAnimation();
+        }
+    }
+}
diff --git a/osu.Game.Rulesets.Taiko/UI/DrawableTaikoJudgement.cs b/osu.Game.Rulesets.Taiko/UI/DrawableTaikoJudgement.cs
index 876fa207bf..dcb7dc25c0 100644
--- a/osu.Game.Rulesets.Taiko/UI/DrawableTaikoJudgement.cs
+++ b/osu.Game.Rulesets.Taiko/UI/DrawableTaikoJudgement.cs
@@ -4,6 +4,7 @@
 using osu.Framework.Graphics;
 using osu.Game.Rulesets.Judgements;
 using osu.Game.Rulesets.Scoring;
+using DefaultJudgementPiece = osu.Game.Rulesets.Taiko.Skinning.Default.DefaultJudgementPiece;
 
 namespace osu.Game.Rulesets.Taiko.UI
 {
@@ -12,31 +13,6 @@ namespace osu.Game.Rulesets.Taiko.UI
     /// </summary>
     public class DrawableTaikoJudgement : DrawableJudgement
     {
-        protected override void ApplyHitAnimations()
-        {
-            this.MoveToY(-100, 500);
-            base.ApplyHitAnimations();
-        }
-
-        protected override Drawable CreateDefaultJudgement(HitResult result) => new TaikoJudgementPiece(result);
-
-        private class TaikoJudgementPiece : DefaultJudgementPiece
-        {
-            public TaikoJudgementPiece(HitResult result)
-                : base(result)
-            {
-            }
-
-            public override void PlayAnimation()
-            {
-                if (Result != HitResult.Miss)
-                {
-                    JudgementText.ScaleTo(0.9f);
-                    JudgementText.ScaleTo(1, 500, Easing.OutElastic);
-                }
-
-                base.PlayAnimation();
-            }
-        }
+        protected override Drawable CreateDefaultJudgement(HitResult result) => new DefaultJudgementPiece(result);
     }
 }