RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify test storage by removing nested storage

This commit is contained in:
Dean Herbert 2023-02-17 13:43:42 +09:00
parent 4560ae6b02
commit 86d110e893
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
osu.Game.Tests/Database/LegacyExporterTest.cs
View File

@ -29,20 +29,16 @@ public void SetUp()
[Test]
public void ExportFileWithNormalNameTest()
{
var exportStorage = storage.GetStorageForDirectory(@"exports");
const string filename = "normal file name";
var item = new TestPathInfo(filename);
Assert.That(item.Filename.Length, Is.LessThan(TestLegacyExporter.MAX_FILENAME_LENGTH));
exportItemAndAssert(item, exportStorage, filename);
exportItemAndAssert(item, filename);
}
[Test]
public void ExportFileWithNormalNameMultipleTimesTest()
{
var exportStorage = storage.GetStorageForDirectory(@"exports");
const string filename = "normal file name";
var item = new TestPathInfo(filename);
@ -52,29 +48,25 @@ public void ExportFileWithNormalNameMultipleTimesTest()
for (int i = 0; i < 10; i++)
{
string expectedFileName = i == 0 ? filename : $"{filename} ({i})";
exportItemAndAssert(item, exportStorage, expectedFileName);
exportItemAndAssert(item, expectedFileName);
}
}
[Test]
public void ExportFileWithSuperLongNameTest()
{
var exportStorage = storage.GetStorageForDirectory(@"exports");
int expectedLength = TestLegacyExporter.MAX_FILENAME_LENGTH - (legacyExporter.GetExtension().Length);
string expectedName = long_filename.Remove(expectedLength);
var item = new TestPathInfo(long_filename);
Assert.That(item.Filename.Length > TestLegacyExporter.MAX_FILENAME_LENGTH, Is.True);
exportItemAndAssert(item, exportStorage, expectedName);
exportItemAndAssert(item, expectedName);
}
[Test]
public void ExportFileWithSuperLongNameMultipleTimesTest()
{
var exportStorage = storage.GetStorageForDirectory(@"exports");
int expectedLength = TestLegacyExporter.MAX_FILENAME_LENGTH - (legacyExporter.GetExtension().Length);
string expectedName = long_filename.Remove(expectedLength);
@ -84,13 +76,13 @@ public void ExportFileWithSuperLongNameMultipleTimesTest()
//Export multiple times
for (int i = 0; i < 10; i++)
exportItemAndAssert(item, exportStorage, expectedName);
exportItemAndAssert(item, expectedName);
}
private void exportItemAndAssert(IHasNamedFiles item, Storage exportStorage, string expectedName)
private void exportItemAndAssert(IHasNamedFiles item, string expectedName)
{
Assert.DoesNotThrow(() => legacyExporter.Export(item));
Assert.That(exportStorage.Exists($"{expectedName}{legacyExporter.GetExtension()}"), Is.True);
Assert.That(storage.Exists($"exports/{expectedName}{legacyExporter.GetExtension()}"), Is.True);
}
[TearDown]