From 8566e93c72f38b9459b4769e1eda18a7d95d4644 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Sat, 20 Aug 2022 17:19:17 +0900
Subject: [PATCH] Guard against `SubmittingPlayer` potentially getting stuck
waiting on request forever
---
osu.Game/Screens/Play/SubmittingPlayer.cs | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/osu.Game/Screens/Play/SubmittingPlayer.cs b/osu.Game/Screens/Play/SubmittingPlayer.cs
index 02a95ae9eb..be77304076 100644
--- a/osu.Game/Screens/Play/SubmittingPlayer.cs
+++ b/osu.Game/Screens/Play/SubmittingPlayer.cs
@@ -8,7 +8,6 @@ using System.Linq;
using System.Threading.Tasks;
using JetBrains.Annotations;
using osu.Framework.Allocation;
-using osu.Framework.Extensions;
using osu.Framework.Logging;
using osu.Framework.Screens;
using osu.Game.Beatmaps;
@@ -84,7 +83,10 @@ namespace osu.Game.Screens.Play
api.Queue(req);
- tcs.Task.WaitSafely();
+ // Generally a timeout would not happen here as APIAccess will timeout first.
+ if (!tcs.Task.Wait(60000))
+ handleTokenFailure(new InvalidOperationException("Token retrieval timed out (request never run)"));
+
return true;
void handleTokenFailure(Exception exception)