From 743dfcc130a4ad2ae7bffdc8d96061468db64f12 Mon Sep 17 00:00:00 2001
From: EVAST9919 <megaman9919@gmail.com>
Date: Sun, 28 May 2017 00:56:11 +0300
Subject: [PATCH] More xmldoc and few Title text fixes
---
.../Tests/TestCaseReplaySettingsOverlay.cs | 2 +-
.../Graphics/UserInterface/SettingsDropdownContainer.cs | 6 +++---
osu.Game/Screens/Play/ReplaySettings/CollectionSettings.cs | 2 +-
osu.Game/Screens/Play/ReplaySettings/DiscussionSettings.cs | 2 +-
osu.Game/Screens/Play/ReplaySettings/PlaybackSettings.cs | 2 +-
.../Screens/Play/ReplaySettings/ReplaySettingsOverlay.cs | 3 +++
6 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/osu.Desktop.VisualTests/Tests/TestCaseReplaySettingsOverlay.cs b/osu.Desktop.VisualTests/Tests/TestCaseReplaySettingsOverlay.cs
index 046e5631b9..4b0c4b8b76 100644
--- a/osu.Desktop.VisualTests/Tests/TestCaseReplaySettingsOverlay.cs
+++ b/osu.Desktop.VisualTests/Tests/TestCaseReplaySettingsOverlay.cs
@@ -50,7 +50,7 @@ namespace osu.Desktop.VisualTests.Tests
private class ExampleContainer : SettingsDropdownContainer
{
- public override string Title => @"EXAMPLE";
+ protected override string Title => @"example";
}
}
}
diff --git a/osu.Game/Graphics/UserInterface/SettingsDropdownContainer.cs b/osu.Game/Graphics/UserInterface/SettingsDropdownContainer.cs
index 15198e06e9..3e7f61b60c 100644
--- a/osu.Game/Graphics/UserInterface/SettingsDropdownContainer.cs
+++ b/osu.Game/Graphics/UserInterface/SettingsDropdownContainer.cs
@@ -14,9 +14,9 @@ namespace osu.Game.Graphics.UserInterface
public abstract class SettingsDropdownContainer : Container
{
/// <summary>
- /// The title of this container.
+ /// The title of this container, which will be written in header.
/// </summary>
- public abstract string Title { get; }
+ protected abstract string Title { get; }
private const float transition_duration = 600;
private const int container_width = 270;
@@ -70,7 +70,7 @@ namespace osu.Game.Graphics.UserInterface
{
Origin = Anchor.CentreLeft,
Anchor = Anchor.CentreLeft,
- Text = Title,
+ Text = Title.ToUpper(),
TextSize = 17,
Font = @"Exo2.0-Bold",
Margin = new MarginPadding { Left = 10 },
diff --git a/osu.Game/Screens/Play/ReplaySettings/CollectionSettings.cs b/osu.Game/Screens/Play/ReplaySettings/CollectionSettings.cs
index a3cd33c5f8..b0a38537ea 100644
--- a/osu.Game/Screens/Play/ReplaySettings/CollectionSettings.cs
+++ b/osu.Game/Screens/Play/ReplaySettings/CollectionSettings.cs
@@ -12,7 +12,7 @@ namespace osu.Game.Screens.Play.ReplaySettings
{
public class CollectionSettings : SettingsDropdownContainer
{
- public override string Title => @"COLLECTIONS";
+ protected override string Title => @"collections";
[BackgroundDependencyLoader]
private void load()
diff --git a/osu.Game/Screens/Play/ReplaySettings/DiscussionSettings.cs b/osu.Game/Screens/Play/ReplaySettings/DiscussionSettings.cs
index 0f295f77aa..4abc772f7d 100644
--- a/osu.Game/Screens/Play/ReplaySettings/DiscussionSettings.cs
+++ b/osu.Game/Screens/Play/ReplaySettings/DiscussionSettings.cs
@@ -11,7 +11,7 @@ namespace osu.Game.Screens.Play.ReplaySettings
{
public class DiscussionSettings : SettingsDropdownContainer
{
- public override string Title => @"DISCUSSIONS";
+ protected override string Title => @"discussions";
[BackgroundDependencyLoader]
private void load(OsuConfigManager config)
diff --git a/osu.Game/Screens/Play/ReplaySettings/PlaybackSettings.cs b/osu.Game/Screens/Play/ReplaySettings/PlaybackSettings.cs
index b79e24a63f..30e0df7bb2 100644
--- a/osu.Game/Screens/Play/ReplaySettings/PlaybackSettings.cs
+++ b/osu.Game/Screens/Play/ReplaySettings/PlaybackSettings.cs
@@ -10,7 +10,7 @@ namespace osu.Game.Screens.Play.ReplaySettings
{
public class PlaybackSettings : SettingsDropdownContainer
{
- public override string Title => @"PLAYBACK";
+ protected override string Title => @"playback";
[BackgroundDependencyLoader]
private void load(OsuConfigManager config)
diff --git a/osu.Game/Screens/Play/ReplaySettings/ReplaySettingsOverlay.cs b/osu.Game/Screens/Play/ReplaySettings/ReplaySettingsOverlay.cs
index 09db3f17ca..619c20eeb4 100644
--- a/osu.Game/Screens/Play/ReplaySettings/ReplaySettingsOverlay.cs
+++ b/osu.Game/Screens/Play/ReplaySettings/ReplaySettingsOverlay.cs
@@ -16,6 +16,9 @@ namespace osu.Game.Screens.Play.ReplaySettings
private bool isVisible;
private bool isAvaliable;
+ /// <summary>
+ /// Allow user to interact with this overlay.
+ /// </summary>
public bool IsAvaliable
{
set