diff --git a/osu.Game/Online/Multiplayer/IMultiplayerClient.cs b/osu.Game/Online/Multiplayer/IMultiplayerClient.cs
index 839ec9bd1f..064065ab00 100644
--- a/osu.Game/Online/Multiplayer/IMultiplayerClient.cs
+++ b/osu.Game/Online/Multiplayer/IMultiplayerClient.cs
@@ -51,23 +51,23 @@ namespace osu.Game.Online.Multiplayer
Task UserStateChanged(int userId, MultiplayerUserState state);
///
- /// Signals that the match ruleset state has changed for a user in this room.
+ /// Signals that the match type state has changed for a user in this room.
///
/// The ID of the user performing a state change.
/// The new state of the user.
- Task MatchRulesetUserStateChanged(int userId, MatchRulesetUserState state);
+ Task MatchUserStateChanged(int userId, MatchUserState state);
///
- /// Signals that the match ruleset state has changed for this room.
+ /// Signals that the match type state has changed for this room.
///
/// The new state of the room.
- Task MatchRulesetRoomStateChanged(MatchRulesetRoomState state);
+ Task MatchRoomStateChanged(MatchRoomState state);
///
- /// Send a match ruleset specific request.
+ /// Send a match type specific request.
///
/// The event to handle.
- Task MatchRulesetEvent(MatchRulesetServerEvent e);
+ Task MatchEvent(MatchServerEvent e);
///
/// Signals that a user in this room changed their beatmap availability state.
diff --git a/osu.Game/Online/Multiplayer/IMultiplayerRoomServer.cs b/osu.Game/Online/Multiplayer/IMultiplayerRoomServer.cs
index 20c9f9e216..b26c4d8201 100644
--- a/osu.Game/Online/Multiplayer/IMultiplayerRoomServer.cs
+++ b/osu.Game/Online/Multiplayer/IMultiplayerRoomServer.cs
@@ -56,10 +56,10 @@ namespace osu.Game.Online.Multiplayer
Task ChangeUserMods(IEnumerable newMods);
///
- /// Send a match ruleset specific request.
+ /// Send a match type specific request.
///
/// The request to send.
- Task SendMatchRulesetRequest(MatchRulesetUserRequest request);
+ Task SendMatchRequest(MatchUserRequest request);
///
/// As the host of a room, start the match.
diff --git a/osu.Game/Online/Multiplayer/MatchRulesetRoomState.cs b/osu.Game/Online/Multiplayer/MatchRoomState.cs
similarity index 56%
rename from osu.Game/Online/Multiplayer/MatchRulesetRoomState.cs
rename to osu.Game/Online/Multiplayer/MatchRoomState.cs
index 105bb1c281..5b662af100 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesetRoomState.cs
+++ b/osu.Game/Online/Multiplayer/MatchRoomState.cs
@@ -3,20 +3,21 @@
using System;
using MessagePack;
-using osu.Game.Online.Multiplayer.MatchRulesets.TeamVs;
+using osu.Game.Online.Multiplayer.MatchTypes.TeamVersus;
#nullable enable
namespace osu.Game.Online.Multiplayer
{
///
- /// Room-wide state for the current match ruleset.
+ /// Room-wide state for the current match type.
/// Can be used to contain any state which should be used before or during match gameplay.
///
[Serializable]
[MessagePackObject]
- [Union(0, typeof(TeamVsMatchRoomState))]
- public class MatchRulesetRoomState // TODO: this will need to be abstract or interface when/if we get messagepack working. for now it isn't as it breaks json serialisation.
+ [Union(0, typeof(TeamVersusRoomState))]
+ // TODO: this will need to be abstract or interface when/if we get messagepack working. for now it isn't as it breaks json serialisation.
+ public class MatchRoomState
{
}
}
diff --git a/osu.Game/Online/Multiplayer/MatchRulesetServerEvent.cs b/osu.Game/Online/Multiplayer/MatchServerEvent.cs
similarity index 89%
rename from osu.Game/Online/Multiplayer/MatchRulesetServerEvent.cs
rename to osu.Game/Online/Multiplayer/MatchServerEvent.cs
index c45615e914..891fb2cc3b 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesetServerEvent.cs
+++ b/osu.Game/Online/Multiplayer/MatchServerEvent.cs
@@ -11,7 +11,7 @@ namespace osu.Game.Online.Multiplayer
///
[Serializable]
[MessagePackObject]
- public abstract class MatchRulesetServerEvent
+ public abstract class MatchServerEvent
{
}
}
diff --git a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/ChangeTeamRequest.cs b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/ChangeTeamRequest.cs
similarity index 68%
rename from osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/ChangeTeamRequest.cs
rename to osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/ChangeTeamRequest.cs
index 5e1d489d39..9c3b07049c 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/ChangeTeamRequest.cs
+++ b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/ChangeTeamRequest.cs
@@ -5,9 +5,9 @@ using MessagePack;
#nullable enable
-namespace osu.Game.Online.Multiplayer.MatchRulesets.TeamVs
+namespace osu.Game.Online.Multiplayer.MatchTypes.TeamVersus
{
- public class ChangeTeamRequest : MatchRulesetUserRequest
+ public class ChangeTeamRequest : MatchUserRequest
{
[Key(0)]
public int TeamID { get; set; }
diff --git a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/MultiplayerTeam.cs b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/MultiplayerTeam.cs
similarity index 87%
rename from osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/MultiplayerTeam.cs
rename to osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/MultiplayerTeam.cs
index f6bf893818..f952dbc1b5 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/MultiplayerTeam.cs
+++ b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/MultiplayerTeam.cs
@@ -6,7 +6,7 @@ using MessagePack;
#nullable enable
-namespace osu.Game.Online.Multiplayer.MatchRulesets.TeamVs
+namespace osu.Game.Online.Multiplayer.MatchTypes.TeamVersus
{
[Serializable]
[MessagePackObject]
diff --git a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/TeamVsMatchRoomState.cs b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/TeamVersusRoomState.cs
similarity index 73%
rename from osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/TeamVsMatchRoomState.cs
rename to osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/TeamVersusRoomState.cs
index 92f67e99bd..91d1aa43d4 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/TeamVsMatchRoomState.cs
+++ b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/TeamVersusRoomState.cs
@@ -6,16 +6,16 @@ using MessagePack;
#nullable enable
-namespace osu.Game.Online.Multiplayer.MatchRulesets.TeamVs
+namespace osu.Game.Online.Multiplayer.MatchTypes.TeamVersus
{
[MessagePackObject]
- public class TeamVsMatchRoomState : MatchRulesetRoomState
+ public class TeamVersusRoomState : MatchRoomState
{
[Key(0)]
public List Teams { get; set; } = new List();
- public static TeamVsMatchRoomState CreateDefault() =>
- new TeamVsMatchRoomState
+ public static TeamVersusRoomState CreateDefault() =>
+ new TeamVersusRoomState
{
Teams =
{
diff --git a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/TeamVsMatchUserState.cs b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/TeamVersusUserState.cs
similarity index 68%
rename from osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/TeamVsMatchUserState.cs
rename to osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/TeamVersusUserState.cs
index 0880787a5a..96a4e2ea99 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesets/TeamVs/TeamVsMatchUserState.cs
+++ b/osu.Game/Online/Multiplayer/MatchTypes/TeamVersus/TeamVersusUserState.cs
@@ -5,9 +5,9 @@ using MessagePack;
#nullable enable
-namespace osu.Game.Online.Multiplayer.MatchRulesets.TeamVs
+namespace osu.Game.Online.Multiplayer.MatchTypes.TeamVersus
{
- public class TeamVsMatchUserState : MatchRulesetUserState
+ public class TeamVersusUserState : MatchUserState
{
[Key(0)]
public int TeamID { get; set; }
diff --git a/osu.Game/Online/Multiplayer/MatchRulesetUserRequest.cs b/osu.Game/Online/Multiplayer/MatchUserRequest.cs
similarity index 83%
rename from osu.Game/Online/Multiplayer/MatchRulesetUserRequest.cs
rename to osu.Game/Online/Multiplayer/MatchUserRequest.cs
index 3cc430a2b7..15c3ad0776 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesetUserRequest.cs
+++ b/osu.Game/Online/Multiplayer/MatchUserRequest.cs
@@ -7,11 +7,11 @@ using MessagePack;
namespace osu.Game.Online.Multiplayer
{
///
- /// A request from a user to perform an action specific to the current match ruleset.
+ /// A request from a user to perform an action specific to the current match type.
///
[Serializable]
[MessagePackObject]
- public abstract class MatchRulesetUserRequest
+ public abstract class MatchUserRequest
{
}
}
diff --git a/osu.Game/Online/Multiplayer/MatchRulesetUserState.cs b/osu.Game/Online/Multiplayer/MatchUserState.cs
similarity index 56%
rename from osu.Game/Online/Multiplayer/MatchRulesetUserState.cs
rename to osu.Game/Online/Multiplayer/MatchUserState.cs
index aa34cdab41..f457191bb5 100644
--- a/osu.Game/Online/Multiplayer/MatchRulesetUserState.cs
+++ b/osu.Game/Online/Multiplayer/MatchUserState.cs
@@ -3,20 +3,21 @@
using System;
using MessagePack;
-using osu.Game.Online.Multiplayer.MatchRulesets.TeamVs;
+using osu.Game.Online.Multiplayer.MatchTypes.TeamVersus;
#nullable enable
namespace osu.Game.Online.Multiplayer
{
///
- /// User specific state for the current match ruleset.
+ /// User specific state for the current match type.
/// Can be used to contain any state which should be used before or during match gameplay.
///
[Serializable]
[MessagePackObject]
- [Union(0, typeof(TeamVsMatchUserState))]
- public class MatchRulesetUserState // TODO: this will need to be abstract or interface when/if we get messagepack working. for now it isn't as it breaks json serialisation.
+ [Union(0, typeof(TeamVersusUserState))]
+ // TODO: this will need to be abstract or interface when/if we get messagepack working. for now it isn't as it breaks json serialisation.
+ public class MatchUserState
{
}
}
diff --git a/osu.Game/Online/Multiplayer/MultiplayerClient.cs b/osu.Game/Online/Multiplayer/MultiplayerClient.cs
index 5220db16b5..873be7f49c 100644
--- a/osu.Game/Online/Multiplayer/MultiplayerClient.cs
+++ b/osu.Game/Online/Multiplayer/MultiplayerClient.cs
@@ -293,7 +293,7 @@ namespace osu.Game.Online.Multiplayer
public abstract Task ChangeUserMods(IEnumerable newMods);
- public abstract Task SendMatchRulesetRequest(MatchRulesetUserRequest request);
+ public abstract Task SendMatchRequest(MatchUserRequest request);
public abstract Task StartMatch();
@@ -422,7 +422,7 @@ namespace osu.Game.Online.Multiplayer
return Task.CompletedTask;
}
- Task IMultiplayerClient.MatchRulesetUserStateChanged(int userId, MatchRulesetUserState state)
+ Task IMultiplayerClient.MatchUserStateChanged(int userId, MatchUserState state)
{
if (Room == null)
return Task.CompletedTask;
@@ -432,14 +432,14 @@ namespace osu.Game.Online.Multiplayer
if (Room == null)
return;
- Room.Users.Single(u => u.UserID == userId).MatchRulesetState = state;
+ Room.Users.Single(u => u.UserID == userId).MatchState = state;
RoomUpdated?.Invoke();
}, false);
return Task.CompletedTask;
}
- Task IMultiplayerClient.MatchRulesetRoomStateChanged(MatchRulesetRoomState state)
+ Task IMultiplayerClient.MatchRoomStateChanged(MatchRoomState state)
{
if (Room == null)
return Task.CompletedTask;
@@ -449,16 +449,16 @@ namespace osu.Game.Online.Multiplayer
if (Room == null)
return;
- Room.MatchRulesetState = state;
+ Room.MatchState = state;
RoomUpdated?.Invoke();
}, false);
return Task.CompletedTask;
}
- public Task MatchRulesetEvent(MatchRulesetServerEvent e)
+ public Task MatchEvent(MatchServerEvent e)
{
- // not used by any match rulesets just yet.
+ // not used by any match types just yet.
return Task.CompletedTask;
}
diff --git a/osu.Game/Online/Multiplayer/MultiplayerRoom.cs b/osu.Game/Online/Multiplayer/MultiplayerRoom.cs
index 07d87fafc3..175c0e0e27 100644
--- a/osu.Game/Online/Multiplayer/MultiplayerRoom.cs
+++ b/osu.Game/Online/Multiplayer/MultiplayerRoom.cs
@@ -48,7 +48,7 @@ namespace osu.Game.Online.Multiplayer
public MultiplayerRoomUser? Host { get; set; }
[Key(5)]
- public MatchRulesetRoomState? MatchRulesetState { get; set; }
+ public MatchRoomState? MatchState { get; set; }
[JsonConstructor]
[SerializationConstructor]
diff --git a/osu.Game/Online/Multiplayer/MultiplayerRoomSettings.cs b/osu.Game/Online/Multiplayer/MultiplayerRoomSettings.cs
index f76ab5da89..706bc750d3 100644
--- a/osu.Game/Online/Multiplayer/MultiplayerRoomSettings.cs
+++ b/osu.Game/Online/Multiplayer/MultiplayerRoomSettings.cs
@@ -41,7 +41,7 @@ namespace osu.Game.Online.Multiplayer
public string Password { get; set; } = string.Empty;
[Key(8)]
- public MatchType MatchRulesetType { get; set; }
+ public MatchType MatchType { get; set; }
public bool Equals(MultiplayerRoomSettings other)
=> BeatmapID == other.BeatmapID
@@ -52,7 +52,7 @@ namespace osu.Game.Online.Multiplayer
&& Password.Equals(other.Password, StringComparison.Ordinal)
&& Name.Equals(other.Name, StringComparison.Ordinal)
&& PlaylistItemId == other.PlaylistItemId
- && MatchRulesetType == other.MatchRulesetType;
+ && MatchType == other.MatchType;
public override string ToString() => $"Name:{Name}"
+ $" Beatmap:{BeatmapID} ({BeatmapChecksum})"
@@ -60,7 +60,7 @@ namespace osu.Game.Online.Multiplayer
+ $" AllowedMods:{string.Join(',', AllowedMods)}"
+ $" Password:{(string.IsNullOrEmpty(Password) ? "no" : "yes")}"
+ $" Ruleset:{RulesetID}"
- + $" MatchRuleset:{MatchRulesetType}"
+ + $" Type:{MatchType}"
+ $" Item:{PlaylistItemId}";
}
}
diff --git a/osu.Game/Online/Multiplayer/MultiplayerRoomUser.cs b/osu.Game/Online/Multiplayer/MultiplayerRoomUser.cs
index 96e9a7fd4a..5d11e2921a 100644
--- a/osu.Game/Online/Multiplayer/MultiplayerRoomUser.cs
+++ b/osu.Game/Online/Multiplayer/MultiplayerRoomUser.cs
@@ -25,7 +25,7 @@ namespace osu.Game.Online.Multiplayer
public MultiplayerUserState State { get; set; } = MultiplayerUserState.Idle;
[Key(4)]
- public MatchRulesetUserState? MatchRulesetState { get; set; }
+ public MatchUserState? MatchState { get; set; }
///
/// The availability state of the current beatmap.
diff --git a/osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs b/osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs
index 1dfc60312b..00f30463a5 100644
--- a/osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs
+++ b/osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs
@@ -58,8 +58,8 @@ namespace osu.Game.Online.Multiplayer
connection.On(nameof(IMultiplayerClient.ResultsReady), ((IMultiplayerClient)this).ResultsReady);
connection.On>(nameof(IMultiplayerClient.UserModsChanged), ((IMultiplayerClient)this).UserModsChanged);
connection.On(nameof(IMultiplayerClient.UserBeatmapAvailabilityChanged), ((IMultiplayerClient)this).UserBeatmapAvailabilityChanged);
- connection.On(nameof(IMultiplayerClient.MatchRulesetRoomStateChanged), ((IMultiplayerClient)this).MatchRulesetRoomStateChanged);
- connection.On(nameof(IMultiplayerClient.MatchRulesetUserStateChanged), ((IMultiplayerClient)this).MatchRulesetUserStateChanged);
+ connection.On(nameof(IMultiplayerClient.MatchRoomStateChanged), ((IMultiplayerClient)this).MatchRoomStateChanged);
+ connection.On(nameof(IMultiplayerClient.MatchUserStateChanged), ((IMultiplayerClient)this).MatchUserStateChanged);
};
IsConnected.BindTo(connector.IsConnected);
@@ -122,12 +122,12 @@ namespace osu.Game.Online.Multiplayer
return connection.InvokeAsync(nameof(IMultiplayerServer.ChangeUserMods), newMods);
}
- public override Task SendMatchRulesetRequest(MatchRulesetUserRequest request)
+ public override Task SendMatchRequest(MatchUserRequest request)
{
if (!IsConnected.Value)
return Task.CompletedTask;
- return connection.InvokeAsync(nameof(IMultiplayerServer.SendMatchRulesetRequest), request);
+ return connection.InvokeAsync(nameof(IMultiplayerServer.SendMatchRequest), request);
}
public override Task StartMatch()
diff --git a/osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs b/osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs
index 6a8bf87ff0..7deecdfa28 100644
--- a/osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs
+++ b/osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs
@@ -192,7 +192,7 @@ namespace osu.Game.Tests.Visual.Multiplayer
return Task.CompletedTask;
}
- public override Task SendMatchRulesetRequest(MatchRulesetUserRequest request) => Task.CompletedTask;
+ public override Task SendMatchRequest(MatchUserRequest request) => Task.CompletedTask;
public override Task StartMatch()
{