From 70cc03fe4304b1c982178bf34601718503dd3547 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 20 Jan 2022 17:18:53 +0900
Subject: [PATCH] Avoid constructor overhead for realm `RealmKeyBinding`
 parameterless constructor

---
 .../Database/TestRealmKeyBindingStore.cs      | 20 +++----------------
 osu.Game/Input/Bindings/RealmKeyBinding.cs    | 20 +++++++++++++++++--
 osu.Game/Input/RealmKeyBindingStore.cs        |  8 +-------
 3 files changed, 22 insertions(+), 26 deletions(-)

diff --git a/osu.Game.Tests/Database/TestRealmKeyBindingStore.cs b/osu.Game.Tests/Database/TestRealmKeyBindingStore.cs
index f05d9ab3dc..e3c1d42667 100644
--- a/osu.Game.Tests/Database/TestRealmKeyBindingStore.cs
+++ b/osu.Game.Tests/Database/TestRealmKeyBindingStore.cs
@@ -63,23 +63,9 @@ namespace osu.Game.Tests.Database
             using (var realm = realmContextFactory.CreateContext())
             using (var transaction = realm.BeginWrite())
             {
-                realm.Add(new RealmKeyBinding
-                {
-                    Action = GlobalAction.Back,
-                    KeyCombination = new KeyCombination(InputKey.A)
-                });
-
-                realm.Add(new RealmKeyBinding
-                {
-                    Action = GlobalAction.Back,
-                    KeyCombination = new KeyCombination(InputKey.S)
-                });
-
-                realm.Add(new RealmKeyBinding
-                {
-                    Action = GlobalAction.Back,
-                    KeyCombination = new KeyCombination(InputKey.D)
-                });
+                realm.Add(new RealmKeyBinding(GlobalAction.Back, new KeyCombination(InputKey.A)));
+                realm.Add(new RealmKeyBinding(GlobalAction.Back, new KeyCombination(InputKey.S)));
+                realm.Add(new RealmKeyBinding(GlobalAction.Back, new KeyCombination(InputKey.D)));
 
                 transaction.Commit();
             }
diff --git a/osu.Game/Input/Bindings/RealmKeyBinding.cs b/osu.Game/Input/Bindings/RealmKeyBinding.cs
index 32813ada16..c941319ddb 100644
--- a/osu.Game/Input/Bindings/RealmKeyBinding.cs
+++ b/osu.Game/Input/Bindings/RealmKeyBinding.cs
@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
+using JetBrains.Annotations;
 using osu.Framework.Input.Bindings;
 using osu.Game.Database;
 using Realms;
@@ -14,7 +15,7 @@ namespace osu.Game.Input.Bindings
     public class RealmKeyBinding : RealmObject, IHasGuidPrimaryKey, IKeyBinding
     {
         [PrimaryKey]
-        public Guid ID { get; set; } = Guid.NewGuid();
+        public Guid ID { get; set; }
 
         public string? RulesetName { get; set; }
 
@@ -38,6 +39,21 @@ namespace osu.Game.Input.Bindings
         public int ActionInt { get; set; }
 
         [MapTo(nameof(KeyCombination))]
-        public string KeyCombinationString { get; set; } = string.Empty;
+        public string KeyCombinationString { get; set; } = null!;
+
+        public RealmKeyBinding(object action, KeyCombination keyCombination, string? rulesetName = null, int? variant = null)
+        {
+            Action = action;
+            KeyCombination = keyCombination;
+
+            RulesetName = rulesetName;
+            Variant = variant;
+            ID = Guid.NewGuid();
+        }
+
+        [UsedImplicitly] // Realm
+        private RealmKeyBinding()
+        {
+        }
     }
 }
diff --git a/osu.Game/Input/RealmKeyBindingStore.cs b/osu.Game/Input/RealmKeyBindingStore.cs
index cb51797685..99f5752cfb 100644
--- a/osu.Game/Input/RealmKeyBindingStore.cs
+++ b/osu.Game/Input/RealmKeyBindingStore.cs
@@ -92,13 +92,7 @@ namespace osu.Game.Input
                 if (defaultsCount > existingCount)
                 {
                     // insert any defaults which are missing.
-                    realm.Add(defaultsForAction.Skip(existingCount).Select(k => new RealmKeyBinding
-                    {
-                        KeyCombinationString = k.KeyCombination.ToString(),
-                        ActionInt = (int)k.Action,
-                        RulesetName = rulesetName,
-                        Variant = variant
-                    }));
+                    realm.Add(defaultsForAction.Skip(existingCount).Select(k => new RealmKeyBinding(k.Action, k.KeyCombination, rulesetName, variant)));
                 }
                 else if (defaultsCount < existingCount)
                 {