RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refine uninstall logic to account for legacy windows features

This commit is contained in:
Susko3 2024-02-26 12:27:02 +01:00
parent 6ded79cf07
commit 6dbba705b3
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Desktop/Windows/WindowsAssociationManager.cs
View File

@ -222,12 +222,21 @@ public void UpdateDescription(RegistryKey classes, string description)
programKey?.SetValue(null, description);
}
/// <summary>
/// Uninstalls the file extenstion association in accordance with https://learn.microsoft.com/en-us/windows/win32/shell/fa-file-types#deleting-registry-information-during-uninstallation
/// </summary>
public void Uninstall(RegistryKey classes)
{
// importantly, we don't delete the default program entry because some other program could have taken it.
using (var extensionKey = classes.OpenSubKey(Extension, true))
{
// clear our default association so that Explorer doesn't show the raw programId to users
// the null/(Default) entry is used for both ProdID association and as a fallback friendly name, for legacy reasons
if (extensionKey?.GetValue(null) is string s && s == programId)
extensionKey.SetValue(null, string.Empty);
using (var extensionKey = classes.OpenSubKey($@"{Extension}\OpenWithProgIds", true))
extensionKey?.DeleteValue(programId, throwOnMissingValue: false);
using (var openWithKey = extensionKey?.CreateSubKey(@"OpenWithProgIds"))
openWithKey?.DeleteValue(programId, throwOnMissingValue: false);
}
classes.DeleteSubKeyTree(programId, throwOnMissingSubKey: false);
}