From 6dab5ee4cfbad32710777b649d5fd5e6cc1d2c3e Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 2 Nov 2023 15:13:43 +0900 Subject: [PATCH] Add support for "argon" default skin to expand columns when on mobile device Should ease those looking to play the game on mobile until we (potentially) have a better solution in the future. If this works out well, we can consider rolling it out to other skins. Closes https://github.com/ppy/osu/issues/23377. --- .../Skinning/Argon/ManiaArgonSkinTransformer.cs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/osu.Game.Rulesets.Mania/Skinning/Argon/ManiaArgonSkinTransformer.cs b/osu.Game.Rulesets.Mania/Skinning/Argon/ManiaArgonSkinTransformer.cs index ddd6365c25..f74b7f1d02 100644 --- a/osu.Game.Rulesets.Mania/Skinning/Argon/ManiaArgonSkinTransformer.cs +++ b/osu.Game.Rulesets.Mania/Skinning/Argon/ManiaArgonSkinTransformer.cs @@ -2,6 +2,7 @@ // See the LICENCE file in the repository root for full licence text. using System; +using osu.Framework; using osu.Framework.Bindables; using osu.Framework.Graphics; using osu.Game.Beatmaps; @@ -99,9 +100,14 @@ public ManiaArgonSkinTransformer(ISkin skin, IBeatmap beatmap) return SkinUtils.As(new Bindable(30)); case LegacyManiaSkinConfigurationLookups.ColumnWidth: - return SkinUtils.As(new Bindable( - stage.IsSpecialColumn(columnIndex) ? 120 : 60 - )); + + float width = 60; + + // Best effort until we have better mobile support. + if (RuntimeInfo.IsMobile) + width = 180 * Math.Min(1, 7f / beatmap.TotalColumns); + + return SkinUtils.As(new Bindable(stage.IsSpecialColumn(columnIndex) ? width * 2 : width)); case LegacyManiaSkinConfigurationLookups.ColumnBackgroundColour: