From 6d9cd0fafe6b405d48fe74061c529bcdf0aaeeac Mon Sep 17 00:00:00 2001
From: smoogipoo <smoogipoo@smgi.me>
Date: Mon, 9 Dec 2019 18:25:13 +0900
Subject: [PATCH] Split out complex method

---
 osu.Game/Rulesets/Objects/SliderPath.cs | 38 ++++++++++++-------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/osu.Game/Rulesets/Objects/SliderPath.cs b/osu.Game/Rulesets/Objects/SliderPath.cs
index d8c6320c6d..6a151d7d33 100644
--- a/osu.Game/Rulesets/Objects/SliderPath.cs
+++ b/osu.Game/Rulesets/Objects/SliderPath.cs
@@ -190,7 +190,7 @@ private void calculatePath()
                 var segmentVertices = vertices.AsSpan().Slice(start, i - start + 1);
                 var segmentType = ControlPoints[start].Type.Value ?? PathType.Linear;
 
-                foreach (Vector2 t in computeSubPath(segmentVertices, segmentType))
+                foreach (Vector2 t in calculateSubPath(segmentVertices, segmentType))
                 {
                     if (calculatedPath.Count == 0 || calculatedPath.Last() != t)
                         calculatedPath.Add(t);
@@ -199,32 +199,32 @@ private void calculatePath()
                 // Start the new segment at the current vertex
                 start = i;
             }
+        }
 
-            static List<Vector2> computeSubPath(ReadOnlySpan<Vector2> subControlPoints, PathType type)
+        private List<Vector2> calculateSubPath(ReadOnlySpan<Vector2> subControlPoints, PathType type)
+        {
+            switch (type)
             {
-                switch (type)
-                {
-                    case PathType.Linear:
-                        return PathApproximator.ApproximateLinear(subControlPoints);
+                case PathType.Linear:
+                    return PathApproximator.ApproximateLinear(subControlPoints);
 
-                    case PathType.PerfectCurve:
-                        if (subControlPoints.Length != 3)
-                            break;
+                case PathType.PerfectCurve:
+                    if (subControlPoints.Length != 3)
+                        break;
 
-                        List<Vector2> subpath = PathApproximator.ApproximateCircularArc(subControlPoints);
+                    List<Vector2> subpath = PathApproximator.ApproximateCircularArc(subControlPoints);
 
-                        // If for some reason a circular arc could not be fit to the 3 given points, fall back to a numerically stable bezier approximation.
-                        if (subpath.Count == 0)
-                            break;
+                    // If for some reason a circular arc could not be fit to the 3 given points, fall back to a numerically stable bezier approximation.
+                    if (subpath.Count == 0)
+                        break;
 
-                        return subpath;
+                    return subpath;
 
-                    case PathType.Catmull:
-                        return PathApproximator.ApproximateCatmull(subControlPoints);
-                }
-
-                return PathApproximator.ApproximateBezier(subControlPoints);
+                case PathType.Catmull:
+                    return PathApproximator.ApproximateCatmull(subControlPoints);
             }
+
+            return PathApproximator.ApproximateBezier(subControlPoints);
         }
 
         private void calculateLength()