RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-09 23:59:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change updateMetrics parameter to be optional

Browse Source
This commit is contained in:
Jamie Taylor 2019-03-14 13:23:31 +09:00
parent dd6fbccb56
commit 69eb4ef983
No known key found for this signature in database
GPG Key ID: 2ACFA8B6370B8C8C
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Screens/Select/BeatmapDetails.cs
View File

@ -9,7 +9,6 @@ using osu.Framework.Graphics.Containers;
using osu.Game.Graphics.Sprites; using osu.Game.Graphics.Sprites;
using osu.Game.Graphics.UserInterface; using osu.Game.Graphics.UserInterface;
using System.Linq; using System.Linq;
using JetBrains.Annotations;
using osu.Game.Online.API; using osu.Game.Online.API;
using osu.Game.Online.API.Requests; using osu.Game.Online.API.Requests;
using osu.Framework.Threading; using osu.Framework.Threading;
@ -202,16 +201,16 @@ namespace osu.Game.Screens.Select
requestedBeatmap.Metrics = res; requestedBeatmap.Metrics = res;
Schedule(() => updateMetrics(res)); Schedule(() => updateMetrics(res));
}; };
lookup.Failure += e => Schedule(() => updateMetrics(null)); lookup.Failure += e => Schedule(() => updateMetrics());
api.Queue(lookup); api.Queue(lookup);
loading.Show(); loading.Show();
return; return;
} }
updateMetrics(null); updateMetrics();
} }
private void updateMetrics([CanBeNull] BeatmapMetrics metrics) private void updateMetrics(BeatmapMetrics metrics = null)
{ {
var hasRatings = metrics?.Ratings?.Any() ?? false; var hasRatings = metrics?.Ratings?.Any() ?? false;
var hasRetriesFails = (metrics?.Retries?.Any() ?? false) && (metrics.Fails?.Any() ?? false); var hasRetriesFails = (metrics?.Retries?.Any() ?? false) && (metrics.Fails?.Any() ?? false);