From 69e2e309717382f6ae63d5b24205a249f089b562 Mon Sep 17 00:00:00 2001
From: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat, 23 Apr 2022 01:06:35 +0300
Subject: [PATCH] Remove legacy skin component fallback lookup

Has always been a source of hiding actual issues like in https://github.com/ppy/osu/issues/17745 (`sliderfollowcircle` looked up from fallback because there's no transformer), and https://github.com/ppy/osu/issues/17934 (because there's a texture `ok` and that matches the component name `HitResult.Ok`).
---
 osu.Game/Skinning/LegacySkin.cs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/osu.Game/Skinning/LegacySkin.cs b/osu.Game/Skinning/LegacySkin.cs
index aed6026d69..1b3b0eea18 100644
--- a/osu.Game/Skinning/LegacySkin.cs
+++ b/osu.Game/Skinning/LegacySkin.cs
@@ -391,9 +391,10 @@ namespace osu.Game.Skinning
                     }
 
                     return null;
-            }
 
-            return this.GetAnimation(component.LookupName, false, false);
+                default:
+                    throw new ArgumentOutOfRangeException(nameof(component));
+            }
         }
 
         private Texture? getParticleTexture(HitResult result)