From 69c23a2371ea9f962981a671a710a763178ceee4 Mon Sep 17 00:00:00 2001
From: Salman Ahmed <frenzibyte@gmail.com>
Date: Tue, 31 Aug 2021 20:06:34 +0300
Subject: [PATCH] Explicitly implement tooltips on date drawables to avoid
 "convert to auto-property" inspections

---
 .../Dashboard/Home/News/FeaturedNewsItemPanel.cs   | 14 ++++++++------
 .../Overlays/Dashboard/Home/News/NewsGroupItem.cs  | 14 ++++++++------
 osu.Game/Overlays/News/NewsCard.cs                 | 12 +++++++-----
 3 files changed, 23 insertions(+), 17 deletions(-)

diff --git a/osu.Game/Overlays/Dashboard/Home/News/FeaturedNewsItemPanel.cs b/osu.Game/Overlays/Dashboard/Home/News/FeaturedNewsItemPanel.cs
index 72a85bcb6c..0d166eb858 100644
--- a/osu.Game/Overlays/Dashboard/Home/News/FeaturedNewsItemPanel.cs
+++ b/osu.Game/Overlays/Dashboard/Home/News/FeaturedNewsItemPanel.cs
@@ -142,13 +142,11 @@ namespace osu.Game.Overlays.Dashboard.Home.News
 
         private class Date : CompositeDrawable, IHasCustomTooltip<DateTimeOffset>
         {
-            public ITooltip<DateTimeOffset> GetCustomTooltip() => new DateTooltip();
-
-            public DateTimeOffset TooltipContent { get; }
+            private readonly DateTimeOffset date;
 
             public Date(DateTimeOffset date)
             {
-                TooltipContent = date;
+                this.date = date;
             }
 
             [BackgroundDependencyLoader]
@@ -172,7 +170,7 @@ namespace osu.Game.Overlays.Dashboard.Home.News
                             Origin = Anchor.TopRight,
                             Font = OsuFont.GetFont(weight: FontWeight.Bold), // using Bold since there is no 800 weight alternative
                             Colour = colourProvider.Light1,
-                            Text = $"{TooltipContent:dd}"
+                            Text = $"{date:dd}"
                         },
                         new TextFlowContainer(f =>
                         {
@@ -183,11 +181,15 @@ namespace osu.Game.Overlays.Dashboard.Home.News
                             Anchor = Anchor.TopRight,
                             Origin = Anchor.TopRight,
                             AutoSizeAxes = Axes.Both,
-                            Text = $"{TooltipContent:MMM yyyy}"
+                            Text = $"{date:MMM yyyy}"
                         }
                     }
                 };
             }
+
+            ITooltip<DateTimeOffset> IHasCustomTooltip<DateTimeOffset>.GetCustomTooltip() => new DateTooltip();
+
+            DateTimeOffset IHasCustomTooltip<DateTimeOffset>.TooltipContent => date;
         }
     }
 }
diff --git a/osu.Game/Overlays/Dashboard/Home/News/NewsGroupItem.cs b/osu.Game/Overlays/Dashboard/Home/News/NewsGroupItem.cs
index a681536156..77cfbc90b0 100644
--- a/osu.Game/Overlays/Dashboard/Home/News/NewsGroupItem.cs
+++ b/osu.Game/Overlays/Dashboard/Home/News/NewsGroupItem.cs
@@ -69,13 +69,11 @@ namespace osu.Game.Overlays.Dashboard.Home.News
 
         private class Date : CompositeDrawable, IHasCustomTooltip<DateTimeOffset>
         {
-            public ITooltip<DateTimeOffset> GetCustomTooltip() => new DateTooltip();
-
-            public DateTimeOffset TooltipContent { get; }
+            private readonly DateTimeOffset date;
 
             public Date(DateTimeOffset date)
             {
-                TooltipContent = date;
+                this.date = date;
             }
 
             [BackgroundDependencyLoader]
@@ -98,16 +96,20 @@ namespace osu.Game.Overlays.Dashboard.Home.News
                     Margin = new MarginPadding { Vertical = 5 }
                 };
 
-                textFlow.AddText($"{TooltipContent:dd}", t =>
+                textFlow.AddText($"{date:dd}", t =>
                 {
                     t.Font = OsuFont.GetFont(size: 14, weight: FontWeight.Bold);
                 });
 
-                textFlow.AddText($"{TooltipContent: MMM}", t =>
+                textFlow.AddText($"{date: MMM}", t =>
                 {
                     t.Font = OsuFont.GetFont(size: 14, weight: FontWeight.Regular);
                 });
             }
+
+            ITooltip<DateTimeOffset> IHasCustomTooltip<DateTimeOffset>.GetCustomTooltip() => new DateTooltip();
+
+            DateTimeOffset IHasCustomTooltip<DateTimeOffset>.TooltipContent => date;
         }
     }
 }
diff --git a/osu.Game/Overlays/News/NewsCard.cs b/osu.Game/Overlays/News/NewsCard.cs
index aee0a50de9..68d0704825 100644
--- a/osu.Game/Overlays/News/NewsCard.cs
+++ b/osu.Game/Overlays/News/NewsCard.cs
@@ -125,13 +125,11 @@ namespace osu.Game.Overlays.News
 
         private class DateContainer : CircularContainer, IHasCustomTooltip<DateTimeOffset>
         {
-            public ITooltip<DateTimeOffset> GetCustomTooltip() => new DateTooltip();
-
-            public DateTimeOffset TooltipContent { get; }
+            private readonly DateTimeOffset date;
 
             public DateContainer(DateTimeOffset date)
             {
-                TooltipContent = date;
+                this.date = date;
             }
 
             [BackgroundDependencyLoader]
@@ -148,7 +146,7 @@ namespace osu.Game.Overlays.News
                     },
                     new OsuSpriteText
                     {
-                        Text = TooltipContent.ToString("d MMM yyyy").ToUpper(),
+                        Text = date.ToString("d MMM yyyy").ToUpper(),
                         Font = OsuFont.GetFont(size: 10, weight: FontWeight.SemiBold),
                         Margin = new MarginPadding
                         {
@@ -160,6 +158,10 @@ namespace osu.Game.Overlays.News
             }
 
             protected override bool OnClick(ClickEvent e) => true; // Protects the NewsCard from clicks while hovering DateContainer
+
+            ITooltip<DateTimeOffset> IHasCustomTooltip<DateTimeOffset>.GetCustomTooltip() => new DateTooltip();
+
+            DateTimeOffset IHasCustomTooltip<DateTimeOffset>.TooltipContent => date;
         }
     }
 }