RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-09 22:57:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not reimplement binary sort manually

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-07-22 17:12:21 +02:00
parent ce78bb549f
commit 699b66be42
No known key found for this signature in database
1 changed files with 13 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
osu.Game/Rulesets/Edit/Checks/CheckBreaks.cs
View File

@ -2,6 +2,7 @@
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq;
using osu.Game.Beatmaps.Timing; using osu.Game.Beatmaps.Timing;
using osu.Game.Rulesets.Edit.Checks.Components; using osu.Game.Rulesets.Edit.Checks.Components;
using osu.Game.Rulesets.Objects; using osu.Game.Rulesets.Objects;
@ -30,66 +31,36 @@ namespace osu.Game.Rulesets.Edit.Checks
public IEnumerable<Issue> Run(BeatmapVerifierContext context) public IEnumerable<Issue> Run(BeatmapVerifierContext context)
{ {
var startTimes = context.Beatmap.HitObjects.Select(ho => ho.StartTime).OrderBy(x => x).ToList();
var endTimes = context.Beatmap.HitObjects.Select(ho => ho.GetEndTime()).OrderBy(x => x).ToList();
foreach (var breakPeriod in context.Beatmap.Breaks) foreach (var breakPeriod in context.Beatmap.Breaks)
{ {
if (breakPeriod.Duration < BreakPeriod.MIN_BREAK_DURATION) if (breakPeriod.Duration < BreakPeriod.MIN_BREAK_DURATION)
yield return new IssueTemplateTooShort(this).Create(breakPeriod.StartTime); yield return new IssueTemplateTooShort(this).Create(breakPeriod.StartTime);
var previousObject = getPreviousObject(breakPeriod.StartTime, context.Beatmap.HitObjects); int previousObjectEndTimeIndex = endTimes.BinarySearch(breakPeriod.StartTime);
var nextObject = getNextObject(breakPeriod.EndTime, context.Beatmap.HitObjects); if (previousObjectEndTimeIndex < 0) previousObjectEndTimeIndex = ~previousObjectEndTimeIndex - 1;
if (previousObject != null) if (previousObjectEndTimeIndex >= 0)
{ {
double gapBeforeBreak = breakPeriod.StartTime - previousObject.GetEndTime(); double gapBeforeBreak = breakPeriod.StartTime - endTimes[previousObjectEndTimeIndex];
if (gapBeforeBreak < minimum_gap_before_break - leniency_threshold) if (gapBeforeBreak < minimum_gap_before_break - leniency_threshold)
yield return new IssueTemplateEarlyStart(this).Create(breakPeriod.StartTime, minimum_gap_before_break - gapBeforeBreak); yield return new IssueTemplateEarlyStart(this).Create(breakPeriod.StartTime, minimum_gap_before_break - gapBeforeBreak);
} }
if (nextObject != null) int nextObjectStartTimeIndex = startTimes.BinarySearch(breakPeriod.EndTime);
if (nextObjectStartTimeIndex < 0) nextObjectStartTimeIndex = ~nextObjectStartTimeIndex;
if (nextObjectStartTimeIndex < startTimes.Count)
{ {
double gapAfterBreak = nextObject.StartTime - breakPeriod.EndTime; double gapAfterBreak = startTimes[nextObjectStartTimeIndex] - breakPeriod.EndTime;
if (gapAfterBreak < min_end_threshold - leniency_threshold) if (gapAfterBreak < min_end_threshold - leniency_threshold)
yield return new IssueTemplateLateEnd(this).Create(breakPeriod.StartTime, min_end_threshold - gapAfterBreak); yield return new IssueTemplateLateEnd(this).Create(breakPeriod.StartTime, min_end_threshold - gapAfterBreak);
} }
} }
} }
private HitObject? getPreviousObject(double time, IReadOnlyList<HitObject> hitObjects)
{
int left = 0;
int right = hitObjects.Count - 1;
while (left <= right)
{
int mid = left + (right - left) / 2;
if (hitObjects[mid].GetEndTime() < time)
left = mid + 1;
else
right = mid - 1;
}
return right >= 0 ? hitObjects[right] : null;
}
private HitObject? getNextObject(double time, IReadOnlyList<HitObject> hitObjects)
{
int left = 0;
int right = hitObjects.Count - 1;
while (left <= right)
{
int mid = left + (right - left) / 2;
if (hitObjects[mid].StartTime <= time)
left = mid + 1;
else
right = mid - 1;
}
return left < hitObjects.Count ? hitObjects[left] : null;
}
public class IssueTemplateEarlyStart : IssueTemplate public class IssueTemplateEarlyStart : IssueTemplate
{ {
public IssueTemplateEarlyStart(ICheck check) public IssueTemplateEarlyStart(ICheck check)